children should not have changes when data is set during parent instantiation - #120
Open
nemophrost wants to merge 3 commits into
Open
children should not have changes when data is set during parent instantiation#120nemophrost wants to merge 3 commits into
nemophrost wants to merge 3 commits into
Conversation
Author
|
Not sure this is best place for solving the problem. Another idea is at line 146, setting Yet another option could be to pass along the initial data for the child to _initChildren and exclude that from the data being set during instantiation. |
…and collections during instantiation
martianboy
approved these changes
Oct 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By have changes I mean calling .hasChanged() should not return true.