Skip to content

a failing test for problem described in #146. No solution, yet. - #147

Open
HenrikJoreteg wants to merge 1 commit into
masterfrom
consistent-parse
Open

a failing test for problem described in #146. No solution, yet.#147
HenrikJoreteg wants to merge 1 commit into
masterfrom
consistent-parse

Conversation

@HenrikJoreteg

Copy link
Copy Markdown
Member

To help state the problem in the form of test.

@kamilogorek

Copy link
Copy Markdown
Contributor

I guess those tests won't work like we'd expect, because they'll give us false positive:

- this[coll] = new this._collections[coll](null, {parent: this});
+ this[coll] = new this._collections[coll](null, {parent: this, parse: true});

- this[child] = new this._children[child]({}, {parent: this});
+ this[child] = new this._children[child]({}, {parent: this, parse: true});

This change itself will fix the tests, but as we initialize those things as an empty, in the end nothing gets parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants