Skip to content

chore(deps): bump amrita-sense to >=1.1.0 and migrate GOTO to JMP - #196

Merged
JohnRichard4096 merged 1 commit into
mainfrom
chore/bump-amrita-sense-1.1.0
Oct 1, 2026
Merged

JohnRichard4096 merged 1 commit into
mainfrom
chore/bump-amrita-sense-1.1.0

Conversation

@AmriaLin

@AmriaLin AmriaLin commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Bumps amrita-sense from >=0.7.0 to >=1.1.0 and migrates the one deprecated API usage in AmritaCore.

Changes

  • pyproject.toml: amrita-sense>=0.7.0 → >=1.1.0 (with a dated note, per the config-change convention)
  • uv.lock: re-locked to amrita-sense 1.1.0
  • src/amrita_core/chatmanager/chat_object.py: GOTO → JMP (import + call)

Why the migration surface is small

AmritaSense 1.0.0 was a breaking instruction-set rename; the old names survive only as static-only deprecation shims and are removed in 2.0. AmritaCore was audited symbol by symbol rather than by reading the changelog:

  • All 31 amrita_sense symbols imported across src/ still exist in 1.1.0.
  • Deprecated names (GOTO / PUSH_STACK / RET_FAR / PUSH_AND_GOTO / INTERRUPT_INTO / INTERRUPT_RET / INTERRUPT / INTERRUPT_KEEP_CTX): only GOTO was used.
  • Not used at all: the CALL meaning change, AbstractCompose.__iter__ removal (1.1.0), pc._jump_marked / pc._if_flag, hard-coded BuiltinTags strings.
  • Depends signature change (cacheable demoted to keyword-only, new use_cache / scope): AmritaCore only calls Depends(POINTER_DEPENDS), so it is unaffected.
  • _compat.py's private _unsafe.__flags__ shim still resolves in 1.1.0 (and is guarded by a fallback anyway).

Verification

  • uv run pytest -q: 442 passed
  • uv run pyright (standard): 0 errors
  • With reportDeprecated=error: the only remaining hits are AmritaCore's own StateContext deprecation (pre-existing, tracked separately), i.e. the GOTO warning is gone.

@sourcery-ai

sourcery-ai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This dependency maintenance change raises amrita-sense to >=1.1.0, updates the lockfile, and migrates AmritaCore’s sole deprecated GOTO usage to JMP while preserving the existing execution flow. The broader symbol audit found no other affected API usages, and the change is verified by 441 passing tests plus clean standard Pyright results.

Sequence diagram for the migrated post-run strategy jump

sequenceDiagram
    participant ChatObject
    participant WorkflowInterpreter
    participant AmritaSense
    ChatObject->>WorkflowInterpreter: _post_runner(chat_obj)
    WorkflowInterpreter->>AmritaSense: JMP(BuiltinName.STRATEGY_EOF)
    AmritaSense-->>WorkflowInterpreter: Continue existing strategy flow
    WorkflowInterpreter-->>ChatObject: Complete post-run processing
Loading

File-Level Changes

Change Details Files
Raise the minimum amrita-sense dependency and refresh the lockfile to the 1.1.0 release.
  • Update the declared dependency floor with the required dated rationale.
  • Re-lock dependencies so amrita-sense resolves to 1.1.0.
pyproject.toml
uv.lock
Replace the deprecated GOTO instruction with its JMP successor in the post-runner strategy pipeline.
  • Switch the instruction import from GOTO to JMP.
  • Preserve the existing jump target and composition of the strategy pipeline.
src/amrita_core/chatmanager/chat_object.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

AmritaSense 1.0.0 was a breaking instruction-set rename; the old names now
survive only as static-only deprecation shims and are removed in 2.0.
AmritaCore's single use of a deprecated name was GOTO in
chatmanager/chat_object.py, migrated to JMP. 1.1.0 also drops __iter__ from
the compose contract, which AmritaCore never relied on.

Every amrita_sense symbol imported across src/ was audited: all 31 still
exist in 1.1.0. The only signature changes are additive
(WorkflowInterpreter.flags / resume_from_halt) or unused
(Depends.use_cache / scope; cacheable demoted to keyword-only).

Verified against amrita-sense 1.1.0: 441 tests pass, pyright (standard)
0 errors. With reportDeprecated enabled the only remaining hits are
AmritaCore's own StateContext deprecation, unrelated to this bump.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@AmriaLin
AmriaLin force-pushed the chore/bump-amrita-sense-1.1.0 branch from f72e4e9 to 50b5177 Compare October 1, 2026 05:13
@JohnRichard4096
JohnRichard4096 merged commit 5bd62bc into main Oct 1, 2026
10 checks passed
@JohnRichard4096
JohnRichard4096 deleted the chore/bump-amrita-sense-1.1.0 branch October 1, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants