chore(deps): bump amrita-sense to >=1.1.0 and migrate GOTO to JMP - #196
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis dependency maintenance change raises amrita-sense to >=1.1.0, updates the lockfile, and migrates AmritaCore’s sole deprecated GOTO usage to JMP while preserving the existing execution flow. The broader symbol audit found no other affected API usages, and the change is verified by 441 passing tests plus clean standard Pyright results. Sequence diagram for the migrated post-run strategy jumpsequenceDiagram
participant ChatObject
participant WorkflowInterpreter
participant AmritaSense
ChatObject->>WorkflowInterpreter: _post_runner(chat_obj)
WorkflowInterpreter->>AmritaSense: JMP(BuiltinName.STRATEGY_EOF)
AmritaSense-->>WorkflowInterpreter: Continue existing strategy flow
WorkflowInterpreter-->>ChatObject: Complete post-run processing
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
AmritaSense 1.0.0 was a breaking instruction-set rename; the old names now survive only as static-only deprecation shims and are removed in 2.0. AmritaCore's single use of a deprecated name was GOTO in chatmanager/chat_object.py, migrated to JMP. 1.1.0 also drops __iter__ from the compose contract, which AmritaCore never relied on. Every amrita_sense symbol imported across src/ was audited: all 31 still exist in 1.1.0. The only signature changes are additive (WorkflowInterpreter.flags / resume_from_halt) or unused (Depends.use_cache / scope; cacheable demoted to keyword-only). Verified against amrita-sense 1.1.0: 441 tests pass, pyright (standard) 0 errors. With reportDeprecated enabled the only remaining hits are AmritaCore's own StateContext deprecation, unrelated to this bump.
AmriaLin
force-pushed
the
chore/bump-amrita-sense-1.1.0
branch
from
October 1, 2026 05:13
f72e4e9 to
50b5177
Compare
JohnRichard4096
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
amrita-sensefrom>=0.7.0to>=1.1.0and migrates the one deprecated API usage in AmritaCore.Changes
pyproject.toml:amrita-sense>=0.7.0→>=1.1.0(with a dated note, per the config-change convention)uv.lock: re-locked toamrita-sense1.1.0src/amrita_core/chatmanager/chat_object.py:GOTO→JMP(import + call)Why the migration surface is small
AmritaSense 1.0.0 was a breaking instruction-set rename; the old names survive only as static-only deprecation shims and are removed in 2.0. AmritaCore was audited symbol by symbol rather than by reading the changelog:
amrita_sensesymbols imported acrosssrc/still exist in 1.1.0.GOTO/PUSH_STACK/RET_FAR/PUSH_AND_GOTO/INTERRUPT_INTO/INTERRUPT_RET/INTERRUPT/INTERRUPT_KEEP_CTX): onlyGOTOwas used.CALLmeaning change,AbstractCompose.__iter__removal (1.1.0),pc._jump_marked/pc._if_flag, hard-codedBuiltinTagsstrings.Dependssignature change (cacheabledemoted to keyword-only, newuse_cache/scope): AmritaCore only callsDepends(POINTER_DEPENDS), so it is unaffected._compat.py's private_unsafe.__flags__shim still resolves in 1.1.0 (and is guarded by a fallback anyway).Verification
uv run pytest -q: 442 passeduv run pyright(standard): 0 errorsreportDeprecated=error: the only remaining hits are AmritaCore's ownStateContextdeprecation (pre-existing, tracked separately), i.e. theGOTOwarning is gone.