Skip to content

Stabilize configurable live playback latency #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xmarre wants to merge 1 commit into from
Closed

Stabilize configurable live playback latency #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions src/Controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,13 @@ export default function Controls(props) {
const [position, setPosition] = useState(undefined);
const [startBuffer, setStartBuffer] = useState(undefined);
const [duration, setDuration] = useState(undefined);
const { player, playerAPI, hls, live, overlayVisible, handleFullscreen, handlePIP, patreon, setPatreonServers, setShowStats, showStats, isMobile, streamData } = props;
const { player, playerAPI, hls, live, liveDelay, setLiveDelay, overlayVisible, handleFullscreen, handlePIP, patreon, setPatreonServers, setShowStats, showStats, isMobile, streamData } = props;
const [currentLevel, setCurrentLevel] = useState(undefined);
const [liveDelayDraft, setLiveDelayDraft] = useState(liveDelay);

useEffect(() => {
setLiveDelayDraft(liveDelay);
}, [liveDelay]);

useEffect(() => {
if (!player) return;
Expand All @@ -38,11 +43,13 @@ export default function Controls(props) {

useEffect(() => {
if (!hls) return;
let cancelled = false;

const initalize = async () => {
while (hls.currentLevel === -1) {
while (!cancelled && hls.currentLevel === -1) {
await sleep(100);
}
if (cancelled || hls.currentLevel === -1 || !hls.levels[hls.currentLevel]) return;

const reversedLevels = hls.levels.slice(0).reverse();
const currentIndex = reversedLevels.findIndex((tmpLevel) => tmpLevel.attrs.VIDEO === hls.levels[hls.currentLevel].attrs.VIDEO);
Expand All @@ -55,6 +62,9 @@ export default function Controls(props) {
};

initalize();
return () => {
cancelled = true;
};
}, [hls]);

const playHandler = () => {
Expand Down Expand Up @@ -103,6 +113,14 @@ export default function Controls(props) {
setPosition(player.currentTime);
};

const handleLiveDelayChange = (e, value) => {
setLiveDelayDraft(Array.isArray(value) ? value[0] : value);
};

const commitLiveDelay = (e, value) => {
setLiveDelay(Array.isArray(value) ? value[0] : value);
};

return (
<Fade in={overlayVisible} onDoubleClick={(e) => e.stopPropagation()}>
<Parent>
Expand Down Expand Up @@ -197,6 +215,23 @@ export default function Controls(props) {
<ListItemText>{`< Back`}</ListItemText>
</MenuItem>
<Divider />
<Box sx={{ px: 2, pt: 1, pb: 1.5 }}>
<Box sx={{ display: "flex", justifyContent: "space-between", mb: 0.5 }}>
<Typography variant="caption">Stable live delay</Typography>
<Typography variant="caption">{`${Number(liveDelayDraft).toFixed(1)}s`}</Typography>
</Box>
<Slider
min={9}
max={60}
step={0.5}
value={liveDelayDraft}
valueLabelDisplay="auto"
valueLabelFormat={(value) => `${value}s`}
onChange={handleLiveDelayChange}
onChangeCommitted={commitLiveDelay}
/>
</Box>
<Divider />
<MenuItem onClick={handlePlaybackStats}>
<ListItemText>Video Stats</ListItemText>
<Switch edge="end" checked={showStats} size="small" />
Expand Down
Loading