feat(desktop): add GoodDollar deposit option - #790
Open
kotevcode wants to merge 1 commit into
Open
Conversation
Adds a Deposit with GoodDollar row under More options. The main process signs an EIP-712 SetOperator authorization for GoodDollar's operator wallet at the buyer's current on-chain nonce and opens their hosted AI-credits page with buyerAddress and operatorSignature query params. URL and operator are overridable via payments.gooddollar config. The row uses GoodDollar's official mark with a Celo network badge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Deposit with GoodDollar" option under More options in the Add Credits chooser, below Meridian.
buyerAddressandoperatorSignaturequery params.SetOperatormessage authorizing GoodDollar's operator wallet (0x192288D921045aa96903e5286E116960e5fb4607), so their side can submitsetOperator()and run the $G deposit without the buyer paying gas.payments.gooddollar.{url,operator}in the desktop config.Note for the GoodDollar side: the signature only covers the initial
setOperator()— if a buyer already has an operator set, the call reverts withOperatorAlreadySetand their page needs atransferOperatorpath instead.CHANGELOG updated under Unreleased.