Desktop telemetry: include which app in app_connect/app_disconnect - #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
user_actionPostHog event forapp_connect/app_disconnectnow carries anappproperty saying which app was connected or disconnected.TELEMETRY_APP_NAMESinshared/telemetry.ts): the packaged profile names (opencode, codex, claude-desktop, hermes, droid, t3code, pi, gooeypi, crush, goose, zed) plustelegram; anything else — user-added custom apps — normalizes tocustom, so raw app names never leave the device, in line with the telemetry allowlisting rules.user_actionsanitize allowlist. The pending-action dedup key includes the app, so connecting two different apps in quick succession emits both events.startProfiles(which also runs on profile switches and custom-app removal restarts, emitting spuriousapp_connect) toconnectProfile/connectAppwhere the specific app is known. Single-app disconnects now emitapp_disconnectwith the app; full disconnect keeps the un-attributed event.Testing
appproperty.pnpm run testin apps/desktop (main + 350 renderer tests) andpnpm run typecheck:rendererpass.CHANGELOG.md updated.