feat: gracefully drain seller requests on shutdown - #984
Draft
alexanderludwig wants to merge 1 commit into
Draft
Conversation
Stop accepting new work, wait for active requests and final payment authorizations, and drain transport buffers before closing connections. Add configurable shutdown drain timeouts and regression tests. Refs #981
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the graceful-shutdown portion of #981. Refs #981; this PR intentionally does not close the issue because hot pricing reload is covered by a separate draft.
--shutdown-drain-timeout-msor SDKshutdownDrainTimeoutMs; coalesce concurrentstop()calls.PR split / merge order
This is the standalone first PR, targeting
main. The pricing-reload draft #985 onfeat/seller-price-hot-reloadtargets this branch so each review contains only its own feature. Merge this PR first, then retarget #985 tomain.Validation
git diff --check.Limits
The timeout bounds request/payment/transport draining, not subsequent on-chain settlement and cleanup. Forced termination (SIGKILL) cannot drain. No live-chain deployment testing was performed.