Repository navigation
feat: add simple table menus and undoable conversions - #608
Merged
Merged
Conversation
|
Sorry @annieappflowy, your pull request is larger than the review limit of 150,000 diff characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simple tables lacked header switches and a block menu, and converting or deleting a table could lose displayed inline values or leave users unable to restore their content with Undo. This adds the Figma menu designs and makes these actions reversible while preserving content, layout, and keyboard focus.
Menu styling and colors are scoped to simple tables. Database deletion/restoration handling is shared by embedded database blocks generally. Yjs-to-Slate block insertion now follows document order for Undo and remote transactions, including non-table blocks. Local dev-server port and proxy settings are excluded from this PR.
Validation
pnpm run lint, including application type checking and ESLint) passed, along with scoped ESLint checks for the new BDD step files.Checklist
General
Testing
Feature-Specific
Design references
Row and column menus, block menu, and selection state.