Extend api to serve standard builds path list from firmware server#242
Open
shiv-tyagi wants to merge 5 commits into
Open
Extend api to serve standard builds path list from firmware server#242shiv-tyagi wants to merge 5 commits into
shiv-tyagi wants to merge 5 commits into
Conversation
shiv-tyagi
force-pushed
the
ap-metadata-server
branch
from
ffcc1e0 to
1676bbc
Compare
shiv-tyagi
force-pushed
the
ap-metadata-server
branch
from
1676bbc to
6c9211f
Compare
shiv-tyagi
changed the title
peterbarker
reviewed
Jun 26, 2026
| ) | ||
| return None | ||
|
|
||
| def get_board_standard_artifacts_from_fw_server( |
Contributor
There was a problem hiding this comment.
This doesn't look right. Why aren't you using the manifest file? It's there explicitly so this sort of thing is not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firmware.ardupilot.org serves standard builds for a vehicle-version-board combination. This PR extends the /vehicles api on the custom build server to serve the list of the urls for those standard builds.
This work can be independently merged without any UI change as it is an API extension. This will be used in the new custom build server frontend.
I have tested this and it works good.