Add generic test for inverted-Heli flying#33547
Conversation
|
Refactor the inverted-flight maneuver out of HeliQuadInvertedFlight into a shared fly_inverted_flight() helper, and add a generic InvertedFlight test that attempts inverted flight on each heli frame and asserts the set that succeeds matches an expected-pass list: a frame that flies inverted but is not expected to, or an expected frame that does not, fails the test. heli-quad has its own dedicated test. The frames need a more negative collective range to hold inverted, so the test sets H_COL_MIN, H_COL_ANG_MIN and the IM_STB_COL_* points for the duration of the test. Heading is not checked for the traditional frames: a single tail rotor re-trims when inverted and drifts slowly, which is orthogonal to whether the frame can hold inverted altitude (the property under test). The quad keeps its strict heading and per-rotor negative-collective checks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
844dd03 to
128b79e
Compare
|
@peterbarker Wow! You have gone above and beyond on your analysis. I didn't expect the default values to pass and that is why I provided the collective parameter changes. there is one other parameter that probably should be changed to aid in better transition. The default setup has the ATC_RATE_P_MAX and ATC_RATE_R_MAX set to 0 (no limit) but the models don't have infinite pitch and roll rate capability. So I always set a limit to allow the aircraft to keep up with the command model as it commands the roll to inverted and back. I think it would be safe to set those both to 120 deg/s. I don't think it will affect the performance. I really didn't intend to check all frames. I think it is redundant to check Blade360, ddfp tail, ddvp tail, and the gas versions. They are all single main rotor/tail rotor configs. The dual heli is interesting. the yaw problem may be a factor of control reversal since the thrust vector is negative and dual heli's use the lateral component of thrust to generate yaw moments. |
|
Just tested Dual heli and I think you should drop that one from the inverted flight test. I don't have a good fix for dual heli in order for it to have proper yaw control while inverted. So that would just leave you with the one traditional heli config. which I think is all that is needed for now. Sorry, I didn't mean for you to do all that work. |
Summary
Iterates the Heli frames, trying to fly each inverted
Classification & Testing (check all that apply and add your own)
Description
Follow-up I promised in #33521 (and currently has patches from that PR in here).
It's actually only a single patch on top!I rebasedIterates the Heli frames and changes the tuning a little to allow for inverted flight