-
Notifications
You must be signed in to change notification settings - Fork 138
docker: add non root user info #1227
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,6 +55,19 @@ docker run --rm -it --network=host \ | |
| ghcr.io/audionut/upload-assistant:latest /downloads/path/to/content --help | ||
| ``` | ||
|
|
||
| ## Run as non root | ||
| mount `tmp` and `banned` directories to run as a non root user | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix hyphenation and enhance clarity. The term "non-root" should be hyphenated. Additionally, consider adding a brief explanation of why these directories need to be mounted for better user understanding. 📝 Proposed fix-mount `tmp` and `banned` directories to run as a non root user
+Mount `tmp` and `banned` directories to run as a non-root user. These directories require write access, so they must be explicitly mounted when running with a non-root user ID.🧰 Tools🪛 LanguageTool[grammar] ~59-~59: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) 🤖 Prompt for AI Agents |
||
|
|
||
| ``` | ||
| docker run --rm -it --network=host \ | ||
| -u 1000:1000 \ | ||
| -v /full/path/to/config.py:/Upload-Assistant/data/config.py \ | ||
| -v /full/path/to/downloads:/downloads \ | ||
| -v /full/path/to/tmp:/Upload-Assistant/tmp \ | ||
| -v /full/path/to/banned:/Upload-Assistant/data/banned \ | ||
| ghcr.io/audionut/upload-assistant:latest /downloads/path/to/content --help | ||
| ``` | ||
|
Comment on lines
+61
to
+69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add language identifier to code block and consider documenting UID selection. The code block should specify a language identifier for proper syntax highlighting. Additionally, consider adding guidance about the UID/GID values (1000:1000) and how users should adjust them to match their host system user. 📝 Proposed fixFix 1: Add language identifier -```
+```bash
docker run --rm -it --network=host \Optional enhancement: Add note about UID/GID After line 59, consider adding a note like: Mount `tmp` and `banned` directories to run as a non-root user. These directories require write access, so they must be explicitly mounted when running with a non-root user ID.
Replace `1000:1000` with your host user's UID:GID (use `id -u` and `id -g` to find yours). Ensure the mounted directories have appropriate permissions for this user.🧰 Tools🪛 markdownlint-cli2 (0.20.0)[warning] 61-61: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
|
|
||
| ## What is docker? | ||
| Google is your friend | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix hyphenation in section header.
The term "non-root" should be hyphenated as it's a compound adjective modifying "user."
📝 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~58-~58: Use a hyphen to join words.
Context: ...ath/to/content --help ``` ## Run as non root mount
tmpand `banned` directorie...(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents