-
Notifications
You must be signed in to change notification settings - Fork 305
[TV] Make the app a first-class media-session citizen #5740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d058586
Declare the playback services and their permissions in the TV manifest
sztomek 4bbda40
Enable the TV playback service and set up notification channels on st…
sztomek a9b4c12
Merge remote-tracking branch 'origin/main' into feat/tv-media-session
sztomek 775a56f
Address PR comments
sztomek 4e43847
Skip the media session activity on TV so the media card Open action w…
sztomek 650cb22
Open the Now Playing tab when the app is launched from the media card
sztomek 3a7e061
Address PR comments
sztomek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
tv/src/main/java/au/com/shiftyjelly/pocketcasts/TvActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,45 @@ | ||
| package au.com.shiftyjelly.pocketcasts | ||
|
|
||
| import android.content.Intent | ||
| import android.os.Bundle | ||
| import androidx.activity.ComponentActivity | ||
| import androidx.activity.compose.setContent | ||
| import au.com.shiftyjelly.pocketcasts.onboarding.TvOnboardingNavHost | ||
| import au.com.shiftyjelly.pocketcasts.theme.TvTheme | ||
| import dagger.hilt.android.AndroidEntryPoint | ||
| import javax.inject.Inject | ||
|
|
||
| @AndroidEntryPoint | ||
| class TvActivity : ComponentActivity() { | ||
|
|
||
| @Inject | ||
| lateinit var launchRequests: TvLaunchRequests | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| if (savedInstanceState == null) { | ||
| handleLaunchIntent(intent) | ||
| } | ||
| setContent { | ||
| TvTheme { | ||
| TvOnboardingNavHost() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun onNewIntent(intent: Intent) { | ||
| super.onNewIntent(intent) | ||
| setIntent(intent) | ||
| handleLaunchIntent(intent) | ||
| } | ||
|
|
||
| private fun handleLaunchIntent(intent: Intent?) { | ||
| val isMediaCardLaunch = intent != null && | ||
| intent.action == Intent.ACTION_MAIN && | ||
| intent.hasCategory(Intent.CATEGORY_LAUNCHER) && | ||
| !intent.hasCategory(Intent.CATEGORY_LEANBACK_LAUNCHER) | ||
| if (isMediaCardLaunch) { | ||
| launchRequests.requestOpenNowPlaying() | ||
| } | ||
| } | ||
|
sztomek marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
tv/src/main/java/au/com/shiftyjelly/pocketcasts/TvLaunchRequests.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package au.com.shiftyjelly.pocketcasts | ||
|
|
||
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
| import kotlinx.coroutines.channels.Channel | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.receiveAsFlow | ||
|
|
||
| @Singleton | ||
| class TvLaunchRequests @Inject constructor() { | ||
| private val openNowPlayingChannel = Channel<Unit>(Channel.CONFLATED) | ||
|
|
||
| val openNowPlaying: Flow<Unit> = openNowPlayingChannel.receiveAsFlow() | ||
|
|
||
| fun requestOpenNowPlaying() { | ||
| openNowPlayingChannel.trySend(Unit) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.