AINFRA-2526: Support synchronized iOS and tvOS release updates by iangmaia · Pull Request #4586 · Automattic/pocket-casts-ios

iangmaia · 2026-06-22T13:09:17Z

Related to AINFRA-2526
ReleasesV2 PR: 224506-ghe-Automattic/wpcom
Release-toolkit PR: wordpress-mobile/release-toolkit#743

Updates Pocket Casts release automation so iOS and tvOS share release versioning, while build/upload work is split into per-platform retryable CI runs.

Summary

tvOS release builds now use the shared release version/build values.
Release CI now builds/uploads one platform at a time and fails fast when RELEASE_PLATFORM is missing.
iOS owns GitHub release creation and the release Slack announcement; tvOS attaches its archive to the existing release.
GitHub release assets are updated before TestFlight upload and now use release-toolkit's upload_github_release_assets action.
Adds explicit tvOS App Store Connect metadata handling.

Testing

TBD: run a few tests targeting 8.15 before merging for 8.16.

Validated Ruby/shell syntax and fail-fast behavior locally. Full end-to-end validation requires App Store Connect signing/secrets and the release cycle.

Checklist

I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
I have considered adding unit tests for my changes.
I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

SergioEstevao · 2026-06-24T12:23:39Z

@iangmaia can we retarget to the 8.15 release branch so we can test the builds during the 8.15 release cycle? thanks

Copilot

Pull request overview

This PR updates the iOS/tvOS release automation so both platforms share the same release version/build numbers and can be built/uploaded together in the release CI flow.

Changes:

Removes tvOS-specific MARKETING_VERSION = 0.1 overrides so tvOS uses the shared iOS release versioning.
Expands Buildkite release pipelines to build and upload both iOS + tvOS artifacts (TestFlight, Sentry dSYMs, GitHub Release assets).
Extends Fastlane to support tvOS App Store Connect metadata uploads and attaching multiple archives to GitHub releases.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
podcasts.xcodeproj/project.pbxproj	Removes hardcoded tvOS `MARKETING_VERSION` overrides so shared versioning applies.
Pocket Casts TV App/Config/PocketCastsTV.base.xcconfig	Drops the tvOS-specific marketing version override to inherit shared release version values.
fastlane/Fastfile	Adds tvOS metadata lane + factors metadata upload helper; updates GitHub release lane to support multiple archives.
.buildkite/release-builds.yml	Renames steps to reflect synchronized iOS + tvOS release builds/uploads.
.buildkite/commands/release-upload.sh	Uploads both iOS + tvOS builds to TestFlight; uploads both dSYMs to Sentry; creates GitHub release.
.buildkite/commands/release-build.sh	Builds both iOS and tvOS App Store Connect artifacts in the release build step.
.buildkite/commands/build-tvos-app-store.sh	Updates comment clarifying why CI tvOS build numbers are prefixed with `0.`.

iangmaia · 2026-06-29T21:29:34Z

+    upload_assets = Array(archive_zip_paths || [archive_zip_path].compact)
+    upload_assets = [APP_STORE_CONNECT_XCARCHIVE_ZIP_PATH, APP_STORE_CONNECT_TVOS_XCARCHIVE_ZIP_PATH] if upload_assets.empty?



Done in 16e3095.

mokagio · 2026-06-26T05:53:04Z

+  # @param notify_slack [Boolean, nil] If true, sends the GitHub release Slack notification. Defaults to true for iOS, false for tvOS.
+  # @param create_release [Boolean, nil] If true, creates the GitHub Release if missing. Defaults to true for iOS, false for tvOS.
  #
-  lane :trigger_beta_build do |branch_to_build:|
-    trigger_buildkite_release_build(branch: branch_to_build, beta: true)
+  lane :trigger_beta_build do |branch_to_build:, platform: 'ios', notify_slack: nil, create_release: nil|


There's code in the method to handle the nil -> Boolean conversion, but given the YARD docs define both notify_slack and create_release as Boolean only, maybe it would be clearer to do the same here?

Suggested change

# @param notify_slack [Boolean, nil] If true, sends the GitHub release Slack notification. Defaults to true for iOS, false for tvOS.

# @param create_release [Boolean, nil] If true, creates the GitHub Release if missing. Defaults to true for iOS, false for tvOS.

#

lane :trigger_beta_build do |branch_to_build:|

trigger_buildkite_release_build(branch: branch_to_build, beta: true)

lane :trigger_beta_build do |branch_to_build:, platform: 'ios', notify_slack: nil, create_release: nil|

# @param notify_slack [Boolean] If true, sends the GitHub release Slack notification. Defaults to true.

# @param create_release [Boolean] If true, creates the GitHub Release if missing. Defaults to true.

#

lane :trigger_beta_build do |branch_to_build:, platform: 'ios', notify_slack: true, create_release: true|

Done in 5dfd717. I kept the nil default because the default depends on the selected platform; I've also clarified the YARD docs.

mokagio · 2026-06-26T05:53:54Z

+  # @param notify_slack [Boolean, nil] If true, sends the GitHub release Slack notification. Defaults to true for iOS, false for tvOS.
+  # @param create_release [Boolean, nil] If true, creates the GitHub Release if missing. Defaults to true for iOS, false for tvOS.
  #
-  lane :trigger_release_build do |branch_to_build:|
-    trigger_buildkite_release_build(branch: branch_to_build, beta: false)
+  lane :trigger_release_build do |branch_to_build:, platform: 'ios', notify_slack: nil, create_release: nil|


Ditto.

Suggested change

# @param notify_slack [Boolean, nil] If true, sends the GitHub release Slack notification. Defaults to true for iOS, false for tvOS.

# @param create_release [Boolean, nil] If true, creates the GitHub Release if missing. Defaults to true for iOS, false for tvOS.

#

lane :trigger_release_build do |branch_to_build:|

trigger_buildkite_release_build(branch: branch_to_build, beta: false)

lane :trigger_release_build do |branch_to_build:, platform: 'ios', notify_slack: nil, create_release: nil|

# @param notify_slack [Boolean] If true, sends the GitHub release Slack notification. Defaults to true.

# @param create_release [Boolean] If true, creates the GitHub Release if missing. Defaults to true.

#

lane :trigger_release_build do |branch_to_build:, platform: 'ios', notify_slack: true, create_release: true|

Done in 5dfd717. Same reasoning here: using true as the lane default would make omitted tvOS manual triggers create the GitHub release and notify Slack, so I kept the nil check and clarified that it preserves the platform default.

mokagio

@iangmaia looking good so far

SergioEstevao

From my side is looking good to. But I guess only when we test on a release we will be able to see the builds produced?

iangmaia · 2026-06-29T21:29:32Z

@SergioEstevao Re: retargeting to release/8.15: I left the base as trunk; if we want to test it in release/8.15, maybe we could cherry-pick the changes to release/8.15, but in principle I'd rather test it manually first to then run the 8.16 cycle.

iangmaia · 2026-06-29T21:30:22Z

Note that I need to test the PR a bit more before manually running a more substantial test, that's why I was reluctant to put it in ready for review. At the same time, I think it's already in a good state, so I'll do it and update it accordingly.

iangmaia · 2026-06-29T21:39:29Z

Updated the PR to use release-toolkit PR #743 for GitHub release asset uploads. The custom Fastfile upload_github_release_assets helper is removed, the lane now calls the plugin action with replace_existing: true, and the plugin is temporarily pinned to the PR #743 commit until it is released through RubyGems. Done in 650b7ef.

mokagio

Looking good.

I merged wordpress-mobile/release-toolkit#743 and will release a new version, point it here and merge.

iangmaia force-pushed the iangmaia/ainfra-2526-sync-ios-tvos-release-updates branch 2 times, most recently from e4750d3 to 1063256 Compare June 24, 2026 12:21

SergioEstevao added this to the 8.15 ❄️ milestone Jun 24, 2026

SergioEstevao added the Releases label Jun 24, 2026

iangmaia force-pushed the iangmaia/ainfra-2526-sync-ios-tvos-release-updates branch from 1063256 to 86daf6b Compare June 24, 2026 12:27

SergioEstevao changed the base branch from trunk to release/8.15 June 24, 2026 12:54

SergioEstevao changed the base branch from release/8.15 to trunk June 24, 2026 12:55

iangmaia added 2 commits June 24, 2026 16:08

AINFRA-2526: Support synchronized iOS and tvOS releases

7869fa0

Address tvOS release automation review feedback

a2d0165

iangmaia force-pushed the iangmaia/ainfra-2526-sync-ios-tvos-release-updates branch from 86daf6b to a2d0165 Compare June 24, 2026 14:08

iangmaia marked this pull request as ready for review June 24, 2026 14:11

iangmaia requested a review from a team as a code owner June 24, 2026 14:11

Copilot AI review requested due to automatic review settings June 24, 2026 14:11

iangmaia requested a review from a team as a code owner June 24, 2026 14:11

iangmaia requested review from SergioEstevao and removed request for a team June 24, 2026 14:11

Copilot started reviewing on behalf of iangmaia June 24, 2026 14:11 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

iangmaia marked this pull request as draft June 24, 2026 15:27

Separate iOS and tvOS release builds

1d7a7f6

mokagio reviewed Jun 26, 2026

View reviewed changes

SergioEstevao approved these changes Jun 26, 2026

View reviewed changes

iangmaia self-assigned this Jun 29, 2026

iangmaia added the [Type] Tooling Issues related to tooling: build tools, ruby, scripts, etc. label Jun 29, 2026

iangmaia modified the milestones: 8.15 ❄️, 8.16 Jun 29, 2026

Handle missing GitHub release archive assets

16e3095

Clarify release trigger defaults

5dfd717

iangmaia removed the Releases label Jun 29, 2026

iangmaia requested a review from mokagio June 29, 2026 21:30

iangmaia marked this pull request as ready for review June 29, 2026 21:37

Use release-toolkit for GitHub release assets

650b7ef

iangmaia mentioned this pull request Jun 29, 2026

Add GitHub release asset upload action wordpress-mobile/release-toolkit#743

Merged

5 tasks

Fix split release upload retry flow

a5c1cf1

iangmaia force-pushed the iangmaia/ainfra-2526-sync-ios-tvos-release-updates branch from 599d889 to a5c1cf1 Compare June 30, 2026 08:11

mokagio approved these changes Jun 30, 2026

View reviewed changes

Use stable version of release-toolkit, 14.9.0

492186c

mokagio reviewed Jun 30, 2026

View reviewed changes

Comment thread Gemfile Outdated

Remove leftover TODO comment

7f70c9e

mokagio enabled auto-merge June 30, 2026 09:56

mokagio merged commit 69fc563 into trunk Jun 30, 2026
4 checks passed

mokagio deleted the iangmaia/ainfra-2526-sync-ios-tvos-release-updates branch June 30, 2026 10:05

		upload_assets = Array(archive_zip_paths \|\| [archive_zip_path].compact)
		upload_assets = [APP_STORE_CONNECT_XCARCHIVE_ZIP_PATH, APP_STORE_CONNECT_TVOS_XCARCHIVE_ZIP_PATH] if upload_assets.empty?

Uh oh!

Conversation

iangmaia commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Checklist

Uh oh!

SergioEstevao commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

iangmaia Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mokagio Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iangmaia Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mokagio Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

iangmaia Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mokagio left a comment

Choose a reason for hiding this comment

Uh oh!

SergioEstevao left a comment

Choose a reason for hiding this comment

Uh oh!

iangmaia commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iangmaia commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iangmaia commented Jun 29, 2026

Uh oh!

mokagio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iangmaia commented Jun 22, 2026 •

edited

Loading

iangmaia Jun 29, 2026 •

edited

Loading

mokagio Jun 26, 2026 •

edited

Loading

iangmaia Jun 29, 2026 •

edited

Loading

iangmaia Jun 29, 2026 •

edited

Loading

iangmaia commented Jun 29, 2026 •

edited

Loading

iangmaia commented Jun 29, 2026 •

edited

Loading