Skip to content

[AppService] Fix Azure/azure-cli#33688: az functionapp deploy: Fix wrong Content-Type header for zip deployments #33689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: dev
Choose a base branch
from
+34 −1
Draft

[AppService] Fix Azure/azure-cli#33688: az functionapp deploy: Fix wrong Content-Type header for zip deployments #33689

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfd029a
Initial plan
Copilot Jul 1, 2026
fe8263d
[AppService] Fix zip deploy content-type header
Copilot Jul 1, 2026
65741d4
[AppService] Re-run CI after flaky Homebrew timeout
Copilot Jul 1, 2026
6f06c97
Merge branch 'dev' into copilot/az-functionapp-deploy-fix-content-type
a0x1ab Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11361,7 +11361,10 @@ def _build_deploymentstatus_url(cmd, resource_group_name, webapp_name, slot, dep

def _get_ondeploy_headers(params):
if params.src_path:
content_type = 'application/octet-stream'
if params.artifact_type == 'zip':
content_type = 'application/zip'
else:
content_type = 'application/octet-stream'
elif params.src_url:
content_type = 'application/json'
else:
Expand Down
30 changes: 30 additions & 0 deletions ...e-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,36 @@ def _make_params(self):
params.slot = None
return params

@mock.patch('azure.cli.command_modules.appservice.custom._populate_cached_scm_headers')
@mock.patch('azure.cli.command_modules.appservice.custom.get_scm_site_headers', return_value={})
def test_get_ondeploy_headers_uses_zip_content_type_for_zip_artifact(
self, get_scm_site_headers_mock, _populate_cached_headers_mock):
from azure.cli.command_modules.appservice.custom import _get_ondeploy_headers
params = self._make_params()
params.src_path = '/tmp/package.zip'
params.artifact_type = 'zip'

_get_ondeploy_headers(params)

sent_additional_headers = get_scm_site_headers_mock.call_args.kwargs['additional_headers']
self.assertEqual(sent_additional_headers['Content-Type'], 'application/zip')
self.assertEqual(sent_additional_headers['Cache-Control'], 'no-cache')

@mock.patch('azure.cli.command_modules.appservice.custom._populate_cached_scm_headers')
@mock.patch('azure.cli.command_modules.appservice.custom.get_scm_site_headers', return_value={})
def test_get_ondeploy_headers_keeps_octet_stream_for_non_zip_artifact(
self, get_scm_site_headers_mock, _populate_cached_headers_mock):
from azure.cli.command_modules.appservice.custom import _get_ondeploy_headers
params = self._make_params()
params.src_path = '/tmp/package.war'
params.artifact_type = 'war'

_get_ondeploy_headers(params)

sent_additional_headers = get_scm_site_headers_mock.call_args.kwargs['additional_headers']
self.assertEqual(sent_additional_headers['Content-Type'], 'application/octet-stream')
self.assertEqual(sent_additional_headers['Cache-Control'], 'no-cache')

def test_get_or_fetch_scm_url_derives_from_cached_site(self):
from azure.cli.command_modules.appservice.custom import _get_or_fetch_scm_url
from azure.mgmt.web.models import HostType
Expand Down
Loading