fix: handle DNS resolution errors in extension index retrieval (related to #33691)#33695
Open
botbikamordehai2-sketch wants to merge 21 commits into
Open
fix: handle DNS resolution errors in extension index retrieval (related to #33691)#33695botbikamordehai2-sketch wants to merge 21 commits into
botbikamordehai2-sketch wants to merge 21 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-enabled` parameters (Azure#33472)
…on` parameter to support identity assignment restrictions (Azure#32214) Co-authored-by: Mohamed Yilmaz Ibrahim <ibrahimmo@microsoft.com>
…ty api-version to 2025-05-31-preview (Azure#33478)
…aintenanceWindow format in default maintenance configuration (Azure#33431)
…update`: Support scheduled events profile via new parameters `--scheduled-events-api-version` and `--enable-all-instance-down` (Azure#33451)
…and resolve API calling redundancy (Azure#33492)
…aming task and run logs (Azure#33486)
|
Hi @botbikamordehai2-sketch, |
botbikamordehai2-sketch
requested review from
Greedygre,
Juliehzl,
Pan-Qi,
VeryEarly,
howang-ms,
teresaritorto and
yanzhudd
as code owners
botbikamordehai2-sketch
requested review from
DanielMicrosoft,
FumingZhang,
MaddyMicrosoft,
digimaun,
isra-fel,
jsntcy,
naga-nandyala,
necusjz,
notyashhh,
wangzelin007,
xuming-ms and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @botbikamordehai2-sketch! We will review the pull request and get back to you soon. |
Contributor
|
@botbikamordehai2-sketch please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Collaborator
|
handle DNS resolution errors |
Pan-Qi
approved these changes
Jul 3, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
get_indexfunction in_index.pyonly catchesrequests.exceptions.ConnectionError,HTTPError, andValueError. When DNS resolution fails (e.g.,urllib3.exceptions.NameResolutionError), it raises an unhandled exception, leading to a crash.Fix
Added
OSErrorto the caught exceptions tuple, which covers DNS resolution failures likesocket.gaierrorandNameResolutionError. This ensures a user-friendly error message is shown instead of a traceback when the endpoint cannot be resolved.Closes #33691