Align Cosmos retry documentation - #5192
Open
Simon Moreno (simorenoh) wants to merge 1 commit into
Open
Conversation
Correct the documented retry behavior and classifier comments to match the Rust driver implementation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 17dcaadb-e402-4d3c-afb9-2d0d53c3a0e8
|
Azure Pipelines: Successfully started running 1 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Cosmos retry documentation and classifier comments with driver behavior.
Changes:
- Updates retry handling details and budgets.
- Clarifies failover, topology, throttling, and endpoint marking behavior.
- Removes outdated cross-SDK comparisons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
retry_evaluation.rs |
Updates retry classifier documentation. |
ErrorCodesAndRetries.md |
Revises the authoritative retry guide. |
Comment on lines
+256
to
+257
| | Single-write | ✅ PPCB-managed| ❌ Not PPCB-managed (PPAF handles writes)| | ||
| | Multi-write | ✅ PPCB-managed| ✅ PPCB-managed | |
Comment on lines
+13
to
+14
| //! - 503, 429/3092, non-topology 410 → FailoverRetry + mark unavailable | ||
| //! - Other 5xx → FailoverRetry + mark unavailable when the operation allows it |
| # Cosmos DB Rust Driver — Retry Mechanisms and Error Code Handling | ||
|
|
||
| This document describes the target retry behavior for the Azure Cosmos DB Rust driver (`azure_data_cosmos_driver`). It serves as the authoritative specification for how the driver handles errors, retries, and cross-region failover. | ||
| This document describes the implemented retry behavior for the Azure Cosmos DB Rust driver (`azure_data_cosmos_driver`). It serves as the authoritative specification for how the driver handles errors, retries, and cross-region failover. |
Comment on lines
+128
to
+131
| | Context | Action | Budget | | ||
| | ------------------------ | ------------------------------- | ------------------- | | ||
| | Partition topology | Dataflow routing-map refresh | Dataflow retry limit| | ||
| | Other 410 response | Cross-region failover retry | 3 failover attempts | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the retry guide and classifier comments with the Rust driver's implemented behavior.