Skip to content

fix(ble_scanner): register FMDN callback as connectable=False so proxy-relayed advertisements aren't dropped #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heman22union wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ble_scanner): register FMDN callback as connectable=False so proxy-relayed advertisements aren't dropped #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions custom_components/googlefindmy/fmdn_finder/ble_scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,21 @@ def _fmdn_advertisement_callback(
# avoids requesting active scans (no extra power draw).
#
# Note: HA's async_register_callback does not support service_data UUID
# filtering natively, so we pass no matcher and filter ourselves.
# The overhead is minimal — the callback returns immediately for
# non-FMDN advertisements after a single dict lookup.
# filtering natively, so we filter ourselves inside the callback.
#
# A falsy matcher (e.g. None) is NOT "match everything" — HA's
# BluetoothManager treats it as {"connectable": True}
# (homeassistant/components/bluetooth/manager.py), which silently drops
# every advertisement relayed through a non-connectable source. ESPHome
# and Shelly Bluetooth proxies register as non-connectable, so this
# callback never fired for any proxy-heard tracker — only advertisements
# picked up by a connectable local adapter got through. Explicitly
# passing connectable=False disables that filter, so both local-radio
# and proxy-relayed advertisements reach us.
unsub: CALLBACK_TYPE = async_register_callback(
hass,
_fmdn_advertisement_callback,
None, # No matcher — we filter inside the callback
{"connectable": False},
BluetoothScanningMode.PASSIVE,
)

Expand Down