Skip to content

Revert "Document Sandbox camera URL parameters" - #1613

Merged
VicenteCartas merged 1 commit into
BabylonJS:masterfrom
VicenteCartas:revert-sandbox-camera-url-docs
Aug 24, 2026
Merged

Revert "Document Sandbox camera URL parameters"#1613
VicenteCartas merged 1 commit into
BabylonJS:masterfrom
VicenteCartas:revert-sandbox-camera-url-docs

Conversation

@VicenteCartas

Copy link
Copy Markdown
Contributor

🤖 This PR was created by the create-pr skill.

Summary

  • Revert Documentation PR Document Sandbox camera URL parameters #1609 while Babylon.js PR #18807 remains under discussion.
  • Remove the unpublished camera preset and cameraMinZ / cameraLowerRadiusLimit documentation from the live Sandbox page.

Motivation

The documentation was merged before the corresponding Babylon.js feature was accepted and merged. This keeps the published documentation aligned with the currently released Sandbox.

The removed documentation should be re-landed once the implementation discussion in BabylonJS/Babylon.js#18807 is resolved and the feature is merged.

Validation

  • npm run validate:content passed with 805 Markdown files and 0 errors.
  • npm run build passed and generated all 1,402 pages.
  • Documentation tests: 79/80 passed; the sole failure is the pre-existing Windows path-separator assertion in content-graph.test.ts.
  • Revert independently reviewed and verified byte-exact against squash commit 5cdc704f from Document Sandbox camera URL parameters #1609.

@VicenteCartas VicenteCartas added the documentation Improvements or additions to documentation label Aug 24, 2026
@VicenteCartas
VicenteCartas marked this pull request as ready for review August 24, 2026 18:24
@VicenteCartas

Copy link
Copy Markdown
Contributor Author

Self code review completed by the code-review workflow. No issues found.

@bjsplat

bjsplat commented Aug 24, 2026

Copy link
Copy Markdown

@VicenteCartas
VicenteCartas requested review from RaananW and a lite review from Copilot August 24, 2026 18:41
@VicenteCartas
VicenteCartas enabled auto-merge (squash) August 24, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts unpublished Sandbox camera URL documentation to match the released Sandbox.

Changes:

  • Removes cameraMinZ and cameraLowerRadiusLimit documentation.
  • Removes related camera preset notes and example URL.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@VicenteCartas
VicenteCartas merged commit da5b92e into BabylonJS:master Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants