Skip to content

ci: make per-package test matrix respect detect-changes #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OttoAllmendinger wants to merge 1 commit into
base: master
Choose a base branch
from
+49 −37
Open

ci: make per-package test matrix respect detect-changes #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 41 additions & 14 deletions .github/scripts/detect-changes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,65 @@
#!/usr/bin/env node
import { execSync } from 'child_process';
import { appendFileSync } from 'fs';
import { execSync } from "child_process";
import { appendFileSync } from "fs";

const ALL_PACKAGES = ['wasm-bip32', 'wasm-mps', 'wasm-utxo', 'wasm-solana', 'wasm-dot', 'wasm-ton', 'wasm-privacy-coin'];
// Per-package matrix entries. Each object becomes one `matrix.include`
// combination in the `test` job. The flags gate steps there:
// - needs-wasm-pack: download the build artifact (wasm .js/.wasm)
// - has-wasm-pack-tests: run `npm run test:wasm-pack-{node,chrome}`
// Keeping the flags here (instead of a static `include:` block in the
// workflow) is what actually lets `detect-changes` shrink the matrix — a
// workflow `include:` entry whose `package` conflicts with the base matrix
// spawns a NEW job rather than being filtered out, which previously
// re-added every package on every PR.
const PACKAGE_CONFIG = [
{ package: "wasm-utxo", "needs-wasm-pack": true, "has-wasm-pack-tests": true },
{ package: "wasm-bip32", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
{ package: "wasm-mps", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
{ package: "wasm-solana", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
{ package: "wasm-dot", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
{ package: "wasm-ton", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
{ package: "wasm-privacy-coin", "needs-wasm-pack": false, "has-wasm-pack-tests": false },
];

function setOutput(packages) {
const value = JSON.stringify(packages);
const ALL_PACKAGES = PACKAGE_CONFIG.map((p) => p.package);

function setOutput(entries) {
const value = JSON.stringify(entries);
appendFileSync(process.env.GITHUB_OUTPUT, `packages=${value}\n`);
console.log(`Packages to test: ${value}`);
}

function entriesFor(pkgs) {
const wanted = new Set(pkgs);
return PACKAGE_CONFIG.filter((p) => wanted.has(p.package));
}

// Non-PR events (push to master, workflow_dispatch): run everything
if (process.env.GITHUB_EVENT_NAME !== 'pull_request') {
setOutput(ALL_PACKAGES);
if (process.env.GITHUB_EVENT_NAME !== "pull_request") {
setOutput(PACKAGE_CONFIG);
process.exit(0);
}

const base = process.env.BASE_SHA;
const head = process.env.HEAD_SHA;

const changedFiles = execSync(`git diff --name-only ${base} ${head}`)
.toString().trim().split('\n').filter(Boolean);
.toString()
.trim()
.split("\n")
.filter(Boolean);

// Shared infrastructure changes → run all packages
const sharedChanged = changedFiles.some(f =>
/^(\.github\/|package\.json$|lerna\.json$|package-lock\.json$)/.test(f)
const sharedChanged = changedFiles.some((f) =>
/^(\.github\/|package\.json$|lerna\.json$|package-lock\.json$)/.test(f),
);
if (sharedChanged) {
setOutput(ALL_PACKAGES);
setOutput(PACKAGE_CONFIG);
process.exit(0);
}

// Per-package detection; fall back to all if nothing package-specific changed
const changed = ALL_PACKAGES.filter(pkg =>
changedFiles.some(f => f.startsWith(`packages/${pkg}/`))
const changed = ALL_PACKAGES.filter((pkg) =>
changedFiles.some((f) => f.startsWith(`packages/${pkg}/`)),
);
setOutput(changed.length > 0 ? changed : ALL_PACKAGES);
setOutput(changed.length > 0 ? entriesFor(changed) : PACKAGE_CONFIG);
31 changes: 8 additions & 23 deletions .github/workflows/build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,29 +155,14 @@ jobs:
strategy:
fail-fast: false
matrix:
package: ${{ fromJson(needs.detect-changes.outputs.packages) }}
include:
- package: wasm-utxo
needs-wasm-pack: true
has-wasm-pack-tests: true
- package: wasm-bip32
needs-wasm-pack: false
has-wasm-pack-tests: false
- package: wasm-mps
needs-wasm-pack: false
has-wasm-pack-tests: false
- package: wasm-solana
needs-wasm-pack: false
has-wasm-pack-tests: false
- package: wasm-dot
needs-wasm-pack: false
has-wasm-pack-tests: false
- package: wasm-ton
needs-wasm-pack: false
has-wasm-pack-tests: false
- package: wasm-privacy-coin
needs-wasm-pack: false
has-wasm-pack-tests: false
# `detect-changes` emits an array of objects
# [{package, needs-wasm-pack, has-wasm-pack-tests}, ...] filtered to
# changed packages. Using `include:` here (not a static list keyed on
# `package`) is what makes the matrix actually shrink: a workflow
# `include:` entry whose `package` conflicts with the base matrix
# spawns a NEW job instead of being filtered, which previously
# re-added every package on every PR.
include: ${{ fromJson(needs.detect-changes.outputs.packages) }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
Loading