Repository navigation
test(web): verify PTY persistence instead of retired connection text - #1135
Merged
PurpleCHOIms merged 2 commits intoOct 27, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web integration gate waits up to 90 seconds for a
connectedfooter label that the current CLI no longer renders. The CLI already boots its composer correctly, so the test times out before reaching its meaningful real-PTY draft-persistence and no-agent-run assertions. This blocks the open cleanup PRs despite healthy CLI startup.Wait for the rendered fixture session and composer, then retain the existing actual PTY input, private draft persistence, and exact thread-creation/no-run assertions. Preserve all timeouts and the real HTTP/WebSocket/PTY path. A closed socket now includes its code/reason and captured server output to diagnose early boot failures.
End-to-end verification
Installed locked npm dependencies offline, built shared streaming, and rebuilt the required node-pty native module. On this machine the unchanged original test failed after 90.27 seconds with the rendered composer visible; the revised test passed in 4.93 seconds. The complete web suite then passed 75/75 in 8.61 seconds. No product source, test selection, timeout or authorization behavior changed.
git diff --checkpassed. No production build was needed for this test-only correction.Requested as part of reviewing/fixing all open OSS PRs before merge. Changes recorded in CHAGELOG.md. This is the shared CI dependency for #1132 and #1133; merge it before reconciling their branches.