Repository navigation
fix(cli): list a selectable Qwen model ID without explanatory suffix - #905
Draft
ChazyTheBest wants to merge 2 commits into
Draft
ChazyTheBest wants to merge 2 commits into
ChazyTheBest wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Ollama catalog entry appends an explanatory suffix to the selectable model ID. Selecting that displayed string then stores the suffix as part of the override. List the actual Qwen model ID.
Draft for issue/design discussion: full merge qualification remains incomplete.
Changes
Intent
Blast radius
Tick the row that best matches this change. No branch rule enforces
this — it sets how much scrutiny you owe the diff and whether to wait
for a review. See
docs/adr/0012-retire-codeowners-merge-gate.md.
.semgrep/**. Reaches every OSS user on the next release: request a review and wait for it.Diff budget
Per QUALITY_BAR §Hard limits: ≤ 400 runtime-code lines, ≤ 10 files, 1 logical concern.
docs/**,tests/**,.github/**,.semgrep/**are excluded.large-diff-approvedfrom@PurpleCHOImsbecause:End-to-end verification
Run /model, copy its first Ollama entry and submit that value to /model. The actual command regression failed on main because the stored override included "(or your OLLAMA_MODEL)"; it passed after the one-line fix. The test-first and fix commits remain separate. This used retained Vitest 2.1.9 rather than the current manifest's 3.2.7, and did not start an interactive Ink session or provider call.
node <retained-cli>/node_modules/vitest/vitest.mjs run --config <owned-scratch>/cli-check.config.mjs: passed. Existing Vitest runner, real model command and override store; no provider request or interactive Ink sessionHonest gap: no live application stack or remote service was activated. Exact-current Python/Next/Vitest dependencies are not installed in this preparation checkout; retained same-client tooling was used for the focused checks above.
make quality,make smoke, a current full build, real browser/PTY/provider/Neo4j/sandbox integration and all changed failure paths have not been verified. The full merge checklists are intentionally left unticked.Required. One paragraph naming the exact commands you ran on your
machine and the exact behavior you observed. "Tested locally," "all
tests pass," and "should work" are not verification statements — they
are reasons to close the PR. See
QUALITY_BAR §Wired end-to-end.
If you genuinely could not run a part of the change locally, say so
explicitly here and name what you did instead.
Testing
Observed focused-check output:
Outstanding qualification:
Full CLI typecheck/test suite and an interactive terminal session remain unverified.
make qualitypasses (Python + CLI + Web)make smokesucceeds (clean local build + OSS-style up + health checks)pytest tests/passes (run this if you toucheddocker-compose.ymlortests/)Every new/changed test was watched to fail without the change and pass with it
Every new/changed code path was executed on my machine, not just unit-tested in isolation
Manual testing (describe):
Quality Bar self-check
Confirm — by ticking — that you have personally verified each item
against your diff. These are conditions of merge per
QUALITY_BAR.md and
CONTRIBUTING_AGENT.md, regardless of
whether AI assistance was used.
except Exception: pass, no bareexcept, no bare# type: ignore/# noqa, no_ = call(), noprint(in production code, no mutable defaults, no wildcard imports, noTODOwithout issue link, noraise NotImplementedErrorin a delivered feature, nopytest.mark.skip/xfailwithout linked issue, no mocked-system-under-test, no# pragma: no coverfor coverage chasing).if x is not None:the types already prove, no helper-used-once, no speculative**kwargs, nodata/result/itemplaceholder names, no docstrings restating the signature, no em-dash salad, no "leverages X to robustly handle Y").AI-assisted contribution attestation
By opening this PR, you confirm — whether or not AI assistance was
used — that you followed CONTRIBUTING_AGENT.md
and meet the QUALITY_BAR.md:
EngagementContext, OPSEC skills, semgrep rules, compose isolation,
capability / PID / memory limits) without a linked ADR.
diff is not raw model output.
No checkbox is required for this section. The bar applies whether or
not you disclose tool use; this section exists so the expectation is
visible at the point of contribution.
Related Issues
Related to #904. Draft; merge conditions remain open.