Conversation
Blaizzy
left a comment
There was a problem hiding this comment.
Could you remove the "MLX" from the name?
The model repo already has tags to identify it as a supported model :)
Blaizzy
left a comment
There was a problem hiding this comment.
Looks good overall just a few nits before we can merge
|
Addressed. Changes in this update:
I also added a small generic Re-validated locally after the change:
|
Signed-off-by: Prince Canuma <prince.gdt@gmail.com>
|
Thanks @ailuntx for the patience! To make it easier, I will make the changes and you can look at what to improve in future PRs. I would suggest asking the agent to follow the format of other existing models and not edit core files like the utils and loading paths. |
|
Updated the branch to keep the MiMo changes within the model integration path. Changes since your comment:
The latest workflow runs are currently marked |
| - [MiMo-V2.5-ASR](https://huggingface.co/mlx-community/MiMo-V2.5-ASR-MLX) | ||
|
|
||
| The model repo resolves its audio tokenizer from `mlx-community/MiMo-Audio-Tokenizer` | ||
| via `mlx_manifest.json`, so the default Hugging Face path works without extra |
There was a problem hiding this comment.
The mlx_manifest.json comment here isn't accurate, can we remove that?
Signed-off-by: Lucas Newman <lucasnewman@me.com>
Add
MiMo-V2.5-ASRsupport tomlx-audioSTT.Changes:
mimo_v2_asrmodel familymlx_audio.stt.load()MiMo-Audio-Tokenizerdependency frommlx_manifest.jsonValidation:
intention.wav->Intention.conversational_a.wav-> expected coffee / Kaldi paragraphCloses #718.