ast: make each use declaration atomic - #416
Merged
Merged
Conversation
LesterEvSe
approved these changes
Sep 8, 2026
Collaborator
There was a problem hiding this comment.
ACK 4a3cc94; tested locally with just check and just check_fuzz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes each use declaration atomic: either every import succeeds, or the scope remains unchanged
Previously,
use source::{Good, Missing};could insertGoodbefore failing onMissing. The change stages imports temporarily and commits them only after the whole declaration succeedsThis prepares the compiler to recover from errors and report multiple diagnostics without leaked imports affecting later analysis