Repository navigation
tests: add soundness tests - #432
Merged
stringhandler merged 2 commits intoOct 13, 2026
Merged
Conversation
Collaborator
Author
|
Note that this does break the rule that a commit may not remove code introduced in a previous commit, because the first commit just adds the single test files, and the second commit fixes the ones identified as |
stringhandler
force-pushed
the
st-soundness-tests
branch
from
October 13, 2026 13:32
395c3ba to
9ea8c3e
Compare
KyrylR
approved these changes
Oct 13, 2026
Each file in functional-tests/error-test-cases/single-file names the Error variant it must produce. One test compiles every file and checks that the named variant is among its diagnostics, so a check that stops firing fails the test. A table in src/error_cases.rs lists every Error variant with an exhaustive match, so a new variant does not compile until it has a case file or a reason it has none (covered elsewhere, untestable, or a known gap). Assisted-by: Claude
Add unit tests where the errors are raised: ExternalFileNotFound and FileNotFound in resolution, FileNotFound for an unreadable import in the driver, and RawHashJetsUnavailable with a jet hinter that lacks the SHA-256 context jets. Point the coverage table at these and at the existing resolution tests for the other dependency errors. No variant is left uncovered, so drop the Gap status. Assisted-by: Claude
stringhandler
force-pushed
the
st-soundness-tests
branch
from
October 13, 2026 14:05
9ea8c3e to
79b2156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a set of tests to cover all errors. Each error will either have a
.simffile that reproduces it, or a link to the unit test.The purpose is to cover the possibility of allowing an error in future. I think this structure should at least help us when adding new Errors.
There are a few errors that are never generated in the code, and they are marked
Untestable. I'll either create issues for these or fixes.Mostly generated by LLM.