Skip to content

rust-bitcoin dep has wrong version #312

Description

@apoelstra

We have a bitcoin dep pulled in by rust-elements at version 0.32.0. But the actual minimum is 0.32.2 (anything lower won't work with rust-elements). We should bump our minimum version to 0.32.2.

Having said this, why do we depend on bitcoin separately for interop with elements? Can't we just use the rust-bitcoin reexport from rust-elements?

The elements/bitcoin dependency was added in b2e9fb6 in #249 for the sake of Weight. We may want to just wait for bitcoin-units 1.0 to resolve this, which will unify the Weight type between rust-bitcoin and rust-elements.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions