Repository navigation
docs(sdk): fix wrong rustdoc for finalize_strict and UTXO unblinded g… - #192
Merged
Merged
Conversation
…etters `Signer::finalize_strict` was described as working against a "confirmation window (in blocks)", but its `fee_rate` argument is a fee rate in sats/kvb. Describe what it does and list its errors. `UTXO::unblinded_amount` was documented to panic "if the UTXO is not confidential". Both unblinded getters panic when `secrets` is `None`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
schoen
force-pushed
the
docs/rustdoc-fixes
branch
from
November 2, 2026 21:57
6d24a95 to
357f23e
Compare
Contributor
Author
|
I don't understand why this CI test failed (with an upstream 403 for |
Contributor
Author
|
Let's see if the CI passes on reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…etters
Signer::finalize_strictwas described as working against a "confirmation window (in blocks)", but itsfee_rateargument is a fee rate in sats/kvb. Describe what it does and list its errors.UTXO::unblinded_amountwas documented to panic "if the UTXO is not confidential". Both unblinded getters panic whensecretsisNone.