Repository navigation
fix(test): flush remaining regular-test execution logs - #202
Merged
Arvolear merged 2 commits intoNov 10, 2026
Merged
Conversation
Fixes BlockstreamResearch#170. Written by Codex.
Arvolear
force-pushed
the
fix/regular-test-trace-flush
branch
from
November 10, 2026 15:18
f245801 to
5a71e7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regular tests that execute a program directly can leave requested verbose output buffered when the test returns, catches an execution failure, or panics. Those paths bypass the Signer's log flush.
Flush the remaining buffers when the regular test context is dropped, before existing node cleanup. Output already flushed by the Signer or explicitly by the caller stays cleared and isn't printed again. SDK execution and fee-estimation buffering are unchanged: direct SDK callers still own per-execution flushing, and a later execution can replace an earlier buffer for the same input. This change doesn't promise a complete execution history.
Fixes #170.
Validation:
a1bf060, node-free probes reproduce missing traces for direct successful and failed execution, including after a regular context is dropped. Explicit flushing prints the buffered DBG/jet output.cargo test --locked --offline -p smplx-sdk -p smplx-test: 104 tests pass. One ignored helper is intentionally invoked in fresh subprocesses so each scenario owns its GlobalConfig and its stderr can be checked.cargo clippy --locked --offline -p smplx-sdk -p smplx-test --all-targets -- -D warningsandcargo fmt --all --checkpass.Written by Codex.