feat: add Codex integration stack surfaces - #8
Conversation
There was a problem hiding this comment.
Sorry @Boulea7, your pull request is larger than the review limit of 150000 diff characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
6 issues found across 48 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/skills-command.test.ts">
<violation number="1" location="test/skills-command.test.ts:18">
P2: Teardown does not correctly restore an originally unset `HOME` environment variable.</violation>
</file>
<file name="src/lib/integration/retrieval-contract.ts">
<violation number="1" location="src/lib/integration/retrieval-contract.ts:113">
P2: `appendCliCwdFlag` uses JSON escaping for shell command construction, which can allow shell expansion (`$...`, `$(...)`) in `--cwd` values.</violation>
</file>
<file name="test/integrations-command.test.ts">
<violation number="1" location="test/integrations-command.test.ts:67">
P2: Restore `HOME` with delete-on-undefined semantics; direct assignment can leave an invalid env value when HOME was originally unset.</violation>
</file>
<file name="docs/claude-reference.en.md">
<violation number="1" location="docs/claude-reference.en.md:95">
P2: Section 6 heading is duplicated with section 7, but section 6 content is actually about `autoMemoryDirectory` config-safety boundaries.</violation>
</file>
<file name="test/recall-command.test.ts">
<violation number="1" location="test/recall-command.test.ts:23">
P2: Teardown incorrectly restores HOME when it was originally unset; assigning `undefined` to `process.env.HOME` produces the literal string `"undefined"` instead of removing the variable.</violation>
</file>
<file name="docs/native-migration.md">
<violation number="1" location="docs/native-migration.md:6">
P2: This Chinese-side scope rewrite is not mirrored in the English counterpart, creating cross-language contract drift for a core design doc.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
10a9eb4 to
e463dc1
Compare
e463dc1 to
71e5532
Compare
…2026-04-11 issue5 tail closeout blocker fixes
issue5 tail invalid cwd closure
issue5 close remaining runtime and extractor seams
…on-parity issue5 release gate isolation parity
issue5 init idempotency and force semantics
…sure issue5 keep session inspection read-only
issue5 runtime safety closure
…ediation issue5 runtime contract remediation
…oundaries issue5 claude and gemini host boundaries
…osure issue5 integrations install AGENTS boundary docs
issue5 wave3 contract closure
…sure issue5 release contract closure
issue5 route truth contracts
…06-startup-reviewer-provenance-v3
…sue5-05-continuity-rollout-signals
…ignals issue5 continuity rollout signals
…ewer issue5 manual mutation reviewer
issue5 retrieval sidecar and fallback diagnostics
issue5 Codex integration stack surfaces
Summary
Test plan
pnpm test:docs-contractpnpm vitest run test/hooks-command.test.ts test/integrations-command.test.ts test/mcp-command.test.ts test/skills-command.test.ts test/recall-command.test.tspnpm build && pnpm test:dist-cli-smoke && pnpm pack:check && pnpm test:tarball-install-smokeNotes
pr/issue5-01-foundationso review stays focused on the integration layer only.Summary by cubic
Adds Codex integration stack surfaces with read‑only retrieval via CLI and a local MCP server, plus new retrieval health checks, a sidecar index with reindexing, and a manual mutation reviewer. Docs shift to a Codex‑first Hybrid model with safety‑gated guidance and tighter workflow/release contracts; the wrapper path stays primary.
New Features
cam recall (search|timeline|details)with the recommended preset (state=auto, limit=8); local MCP server (cam mcp serve) exposessearch_memories,timeline_memories,get_memory_detailsvia@modelcontextprotocol/sdk. Adds a retrieval sidecar index andcam memory reindex(reports lineage/reviewer warnings). Doctor now surfaces retrieval health and repair hints. All surfaces support structured JSON for integrations.cam mcp(print-config|install|doctor|apply-guidance) with project‑scoped installs for hosts (codex,claude,gemini,generic);doctorvalidates canonical server config, route truth, and project pinning;print-configsupports manual wiring forgeneric.cam integrations(install|apply|doctor) with safety‑gatedAGENTS.mdapply, clear fallback semantics, a route summary, and next steps.cam hooks installpins capture/recall helper versions, installs a local bridge bundle and retrieval sidecar index;cam skills install --surface <runtime|official-user|official-project>installs Codex skill assets.cam remember/cam forgetproduce review entries and follow‑up guidance, with lifecycle classification and safe text helpers.docs/host-surfaces.md,docs/host-integration-claude-gemini.md,docs/integration-strategy.md, andAGENTS.md; release checklist tightened; expanded tests for new commands and contracts.Migration
cam mcp install --host codex→cam mcp doctor→cam mcp serve.cam integrations install→cam integrations doctor→cam integrations apply(safety‑gated).cam hooks install;cam skills install --surface <runtime|official-user|official-project>;cam memory reindex.cam recall search(uses the recommended preset by default).Written for commit b70d256. Summary will update on new commits.