Skip to content

Add optional label gate for PR Visual Recap#2284

Merged
steve8708 merged 1 commit into
BuilderIO:mainfrom
CheckPickerUpper:codex/visual-recap-label-gate
Jul 21, 2026
Merged

Add optional label gate for PR Visual Recap#2284
steve8708 merged 1 commit into
BuilderIO:mainfrom
CheckPickerUpper:codex/visual-recap-label-gate

Conversation

@CheckPickerUpper

Copy link
Copy Markdown
Contributor

Summary

  • add VISUAL_RECAP_REQUIRED_LABELS / reusable required-labels so recaps can be opt-in by PR label
  • include the labeled pull_request event so applying an allowed label starts the recap immediately
  • update setup/generated reusable caller docs, add gate tests, and add a recap-cli changeset

Verification

  • pnpm --dir packages/recap-cli test
  • pnpm --dir packages/recap-cli typecheck
  • pnpm --dir packages/recap-cli build
  • git diff --check

Notes

  • English docs are updated; localized pr-visual-recap.mdx copies still need the new variable translated in a localization follow-up.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Visual recap — skipped

The visual recap job did not run for this pull request. This is informational only and does not block the PR.

Recap skipped for 470f4af: external fork PR requires a maintainer to apply the recap label to the current head SHA.

@CheckPickerUpper
CheckPickerUpper force-pushed the codex/visual-recap-label-gate branch from 465ad18 to 187436a Compare July 21, 2026 05:09
builder-io-integration[bot]

This comment was marked as outdated.

@CheckPickerUpper
CheckPickerUpper force-pushed the codex/visual-recap-label-gate branch from 187436a to c374305 Compare July 21, 2026 05:30
builder-io-integration[bot]

This comment was marked as outdated.

@steve8708

Copy link
Copy Markdown
Contributor

thanks @CheckPickerUpper! couple AI review comments worth taking a look at

@CheckPickerUpper
CheckPickerUpper force-pushed the codex/visual-recap-label-gate branch from c374305 to bfd2bfe Compare July 21, 2026 18:03
@CheckPickerUpper
CheckPickerUpper force-pushed the codex/visual-recap-label-gate branch from bfd2bfe to 470f4af Compare July 21, 2026 18:05

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

Reviewed the latest PR head after the workflow-generation fixes. Both previously reported issues are resolved: the CLI-generated reusable caller now derives its labeled-event condition from whether the configured label value is present, and the skills installer now emits the labeled/closed triggers plus the required-labels forwarding. I resolved both stale review threads before submitting this review.

The latest diff also updates all localized workflow snippets, expands installer and builder tests for label-trigger behavior, and preserves the case-insensitive OR matching in the gate implementation. No additional confirmed bugs were found by the available review workers. Risk level: standard. 🧪 Browser testing: Skipped — PR only modifies backend/config/docs/tests, no UI impact.

@steve8708
steve8708 merged commit f8fe58b into BuilderIO:main Jul 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants