Add optional label gate for PR Visual Recap#2284
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
465ad18 to
187436a
Compare
187436a to
c374305
Compare
|
thanks @CheckPickerUpper! couple AI review comments worth taking a look at |
c374305 to
bfd2bfe
Compare
bfd2bfe to
470f4af
Compare
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
Reviewed the latest PR head after the workflow-generation fixes. Both previously reported issues are resolved: the CLI-generated reusable caller now derives its labeled-event condition from whether the configured label value is present, and the skills installer now emits the labeled/closed triggers plus the required-labels forwarding. I resolved both stale review threads before submitting this review.
The latest diff also updates all localized workflow snippets, expands installer and builder tests for label-trigger behavior, and preserves the case-insensitive OR matching in the gate implementation. No additional confirmed bugs were found by the available review workers. Risk level: standard. 🧪 Browser testing: Skipped — PR only modifies backend/config/docs/tests, no UI impact.
Summary
VISUAL_RECAP_REQUIRED_LABELS/ reusablerequired-labelsso recaps can be opt-in by PR labellabeledpull_request event so applying an allowed label starts the recap immediatelyVerification
pnpm --dir packages/recap-cli testpnpm --dir packages/recap-cli typecheckpnpm --dir packages/recap-cli buildgit diff --checkNotes
pr-visual-recap.mdxcopies still need the new variable translated in a localization follow-up.