Repository navigation
AllDifferentExceptN and AllDifferentExcept0: fix naming and solver interfaces - #1122
Merged
Merged
Conversation
IgnaceBleukx
approved these changes
Oct 12, 2026
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
Collaborator
There was a problem hiding this comment.
Great! Two small comments, not blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses existing issues with the AllDifferentExceptN and AllDifferentExcept0 globals. In this implementation, AllDifferentExcept0 inherits from AllDifferentExceptN, while having its own identifier, "alldifferent_except_0". This allows us to correctly distinguish the two globals when mapping to solver interfaces.