Skip to content

fix: possible PushFilterMin overflow with non-utf8 chars and rainbow mode #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cherry merged 1 commit into from
May 2, 2026
Merged

fix: possible PushFilterMin overflow with non-utf8 chars and rainbow mode #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Download GLuaLint
run: curl -o glualint.zip -L https://github.com/FPtje/GLuaFixer/releases/download/$GLUALINT_VERSION/glualint-$GLUALINT_VERSION-x86_64-linux.zip
env:
Expand Down
6 changes: 6 additions & 0 deletions lua/entities/sammyservers_textscreen/cl_init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ local function AddDrawingInfo(ent, rawData)
if string.len(drawData[i][TEXT]) == 0 or string.len(string.Replace( drawData[i][TEXT], " ", "" )) == 0 then drawData[i][TEXT] = nil end
--Rainbow
drawData[i][RAINBOW] = rawData[i]["rainbow"] or 0
-- Rainbow mode iterates with utf8.codes which errors on invalid UTF-8 and
-- leaves render.PushFilterMin / cam.Start3D2D unbalanced. Fall back to plain
-- rendering for lines that are not valid UTF-8.
if drawData[i][RAINBOW] ~= 0 and drawData[i][TEXT] ~= nil and not utf8.len(drawData[i][TEXT]) then
drawData[i][RAINBOW] = 0
end
end

-- Sort out heights
Expand Down