Skip to content

Fix location service startup type #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisTitusTech merged 2 commits into from
Aug 19, 2026
Merged

Fix location service startup type #4972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
279fb4b
fix(tweaks): use canonical location service startup type
aim9sour Aug 12, 2026
9dc0289
test(tweaks): pin location service startup type
aim9sour Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/tweaks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"service": [
{
"Name": "lfsvc",
"StartupType": "Disable",
"StartupType": "Disabled",
"OriginalType": "Manual"
}
],
Expand Down
18 changes: 18 additions & 0 deletions pester/configs.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,16 @@ Describe "Tweaks config" {
throw ($invalidTweaks -join "`n")
}
}

It "keeps the location service disabled" -TestCases $testCase {
param([string]$Path)

$tweaks = Get-Content -Path $Path -Raw | ConvertFrom-Json
$locationServices = @($tweaks.WPFTweaksLocation.service | Where-Object Name -eq "lfsvc")

$locationServices | Should -HaveCount 1
$locationServices[0].StartupType | Should -Be "Disabled"
}
}

Describe "Preset config" {
Expand Down Expand Up @@ -428,6 +438,7 @@ Describe "UI-rendered config entries" {
$tweaks = Get-WinUtilConfigObject -Name "tweaks"
$requiredFields = @("Content", "category", "panel", "link")
$allowedTypes = @("Button", "Combobox", "Toggle", "ToggleButton")
$allowedServiceStartupTypes = @("Automatic", "AutomaticDelayedStart", "Disabled", "Manual")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
$supportedButtons = Get-WinUtilButtonSwitchNames
$invalidEntries = New-Object System.Collections.Generic.List[string]

Expand Down Expand Up @@ -498,6 +509,13 @@ Describe "UI-rendered config entries" {
foreach ($missingField in (Get-WinUtilMissingRequiredFields -EntryName "$($entry.Name),service" -Entry $serviceEntry -RequiredFields @("Name", "StartupType", "OriginalType"))) {
$invalidEntries.Add($missingField)
}

foreach ($startupTypeField in @("StartupType", "OriginalType")) {
if ((Test-WinUtilHasNonEmptyProperty -Object $serviceEntry -Name $startupTypeField) -and
$allowedServiceStartupTypes -notcontains $serviceEntry.$startupTypeField) {
$invalidEntries.Add("$($entry.Name),service has unsupported $startupTypeField '$($serviceEntry.$startupTypeField)'")
}
}
}
}

Expand Down
Loading