Skip to content

Add EmulationStation and Tailscale entries to applications.json - #4973

Merged
ChrisTitusTech merged 4 commits into
ChrisTitusTech:mainfrom
WilliamWaldrop:patch-3
Aug 19, 2026
Merged

Add EmulationStation and Tailscale entries to applications.json#4973
ChrisTitusTech merged 4 commits into
ChrisTitusTech:mainfrom
WilliamWaldrop:patch-3

Conversation

@WilliamWaldrop

Copy link
Copy Markdown
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactor
  • UI/UX improvement

Description

This just adds two apps to it; nothing else.

Issue related to PR

@github-actions github-actions Bot added the new feature New feature or request label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ead7072f-e526-47d3-9498-e7a3dd67d564

📥 Commits

Reviewing files that changed from the base of the PR and between 0e5d525 and 8f2803a.

📒 Files selected for processing (1)
  • config/applications.json

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added EmulationStation Desktop Edition, Tailscale, and QOwnNotes to the available application catalog.
    • Included each application’s category, package information, description, website link, and open-source status.
    • Updated EmulationStation Desktop Edition’s catalog identifier for improved consistency and discoverability.

Walkthrough

The application catalog now includes records for EmulationStation Desktop Edition, Tailscale, and QOwnNotes. The EmulationStation entry key is now es-de.

Changes

Application catalog

Layer / File(s) Summary
Add application records
config/applications.json
Adds EmulationStation Desktop Edition under Games, Tailscale under Utilities, and QOwnNotes under Document. Each record includes package-manager identifiers and application metadata.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8f280

This PR only adds two application entries, and the current configuration is consistent with the expected application contract; no actionable merge-blocking risk remains beyond normal checks.

Possibly related PRs

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The QOwnNotes application entry is not covered by the linked issue or stated objectives and appears unrelated to the requested changes. Remove the QOwnNotes entry or provide a linked requirement that explicitly includes adding QOwnNotes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the EmulationStation and Tailscale additions, which are central changes in the pull request.
Description check ✅ Passed The description relates to adding applications and references the linked Tailscale issue, although it omits the QOwnNotes entry.
Linked Issues check ✅ Passed The pull request satisfies issue #4914 by restoring Tailscale as an available application option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the slop label Aug 12, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/applications.json`:
- Line 420: Update the `_comment` value to use the possessive “its own set of
emulators” instead of the contraction “it's own set of emulators,” leaving the
rest of the comment unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf72a383-5a56-4c09-88f7-bee285317b0c

📥 Commits

Reviewing files that changed from the base of the PR and between aee3e7a and 5ff714d.

📒 Files selected for processing (1)
  • config/applications.json

Comment thread config/applications.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@WilliamWaldrop

Copy link
Copy Markdown
Contributor Author

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...
⚙️ Run configuration

📥 Commits

📒 Files selected for processing (1)

📝 Walkthrough

🚥 Pre-merge checks | ✅ 4 | ❌ 1

✨ Finishing Touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share

Comment @coderabbitai help to get the list of available commands.

Ai generated slop?????? What do you mean.

@WilliamWaldrop

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@WilliamWaldrop I did not mean that the change is “AI-generated slop.”

“AI-generated summary” labels the source of the PR summary. CodeRabbit generated that text from the diff. It is not a quality judgment about the PR.

For this PR, the summary states that config/applications.json adds entries for EmulationStation, Tailscale, and QOwnNotes. The blank sections appeared because review processing was still in progress.

🐇💭

You are interacting with an AI system.

@WilliamWaldrop

Copy link
Copy Markdown
Contributor Author

lol I forgot about QOwnNote. None of this is slop tho.

@WilliamWaldrop

Copy link
Copy Markdown
Contributor Author

@ChrisTitusTech

@FluffyPunk FluffyPunk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except this absurdly long tag

Comment thread config/applications.json Outdated
WilliamWaldrop and others added 2 commits August 18, 2026 20:58
I'm so sorry I'm late I've had to take a break from this for a bit of health related stuff.

Co-authored-by: Ivan Lepekha <57459428+FluffyPunk@users.noreply.github.com>
@ChrisTitusTech
ChrisTitusTech merged commit 2d0fd43 into ChrisTitusTech:main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request slop

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Feature Request] Tailscale removal?

4 participants