Skip to content

Add accessible name to the font scaling slider - #4993

Merged
ChrisTitusTech merged 1 commit into
ChrisTitusTech:mainfrom
malinfossum:fix/font-scaling-slider-a11y
Aug 19, 2026
Merged

Add accessible name to the font scaling slider#4993
ChrisTitusTech merged 1 commit into
ChrisTitusTech:mainfrom
malinfossum:fix/font-scaling-slider-a11y

Conversation

@malinfossum

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • UI/UX improvement

Description

FontScalingSlider in the font scaling popup has no AutomationProperties.Name, so screen readers (Narrator, NVDA) announce it as an unnamed slider with only a raw numeric value — the surrounding "Small"/"Large"/percentage TextBlocks are not associated with the control. This adds AutomationProperties.Name="Font Scaling" so the slider is announced by name.

One-attribute XAML change, companion to #4992 (which names the popup's toggle button and the other top-bar controls). Verified with .\Compile.ps1 -Run + Narrator; full Pester suite passes (549/549).

Issue related to PR

FontScalingSlider had no AutomationProperties.Name, so screen readers
announce it as an unnamed slider with only a raw numeric value.
Completes the accessible-name coverage of the font scaling popup.
@github-actions github-actions Bot added bug Something isn't working ui update UI/UX improvements labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8d7ab83-3bd6-4e77-b63b-4d9f89ebc20a

📥 Commits

Reviewing files that changed from the base of the PR and between 3f1850f and 3d2fac1.

📒 Files selected for processing (1)
  • xaml/inputXML.xaml

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Accessibility
    • Added a descriptive automation name to the font-scaling slider while preserving its existing alignment and scaling behavior.

Walkthrough

The font-scaling slider now includes the automation name Font Scaling. Its centered alignment and scaling behavior remain unchanged.

Changes

Font Scaling Accessibility

Layer / File(s) Summary
Add slider automation name
xaml/inputXML.xaml
The font-scaling slider adds AutomationProperties.Name="Font Scaling" and retains centered alignment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3d2fa

This localized change gives the font scaling slider an accessible name for screen-reader users without altering its behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding an accessible name to the font scaling slider.
Description check ✅ Passed The description accurately explains the accessibility issue, the XAML change, and the verification performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ChrisTitusTech
ChrisTitusTech merged commit 6066675 into ChrisTitusTech:main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui update UI/UX improvements

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants