fix: preserve selections when config import is invalid - #4994
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesSelection import state
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change validates imported selections before replacing existing state and includes coverage for valid and invalid imports; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afd100756c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (-not $isKnownSelection) { | ||
| throw "Unknown selection key '$cbkey'." |
There was a problem hiding this comment.
Document stale-key import rejection
When an exported configuration contains a key removed or renamed in a newer WinUtil catalog, this condition now aborts the entire import instead of applying the remaining selections. The automation guide currently recommends reusing exported baselines across installations without explaining that imports are catalog-version-dependent, how atomic rejection is reported, or how users should recover; update the user guide alongside this behavior change.
AGENTS.md reference: AGENTS.md:L138-L138
Useful? React with 👍 / 👎.
Summary
Validation