Make .fkst/env.example describe what it can actually do - #3970
Merged
fkst-loning-s-macbook-m5[bot] merged 1 commit intoAug 25, 2026
Merged
Conversation
The template taught twelve FKST_* settings. Exactly one of them works. scripts/bin_bootstrap.sh greps this file for `^BIN=` and never sources it, so every other line a reader copies into .fkst/env is inert. Worse, the settings it taught contradict what the repository does with them. scripts/run.sh unsets FKST_GITHUB_WRITE before `run` so a single department run cannot mutate GitHub, and clears a twenty-eight variable hermetic set before tests so they cannot read host posture -- and every FKST_GITHUB_* and FKST_DEVLOOP_* line in the template was in that set. The file also described `supervise`, an entry point this repository stopped providing when operation moved to fkst-ops. That is residue from the supervise-entry migration: the supply side moved to deployment declarations plus fkst-ops, and the template stayed behind. It now documents the one line it is read for, states where the rest actually comes from, and says plainly why putting host posture here would do nothing twice over. Verified rather than asserted: bin_bootstrap.sh has one `^BIN=` grep and no source of this file; run.sh:406 unsets FKST_GITHUB_WRITE; run.sh:558 is the hermetic clear; bin_bootstrap.sh reads .fkst/substrate-ref for the pinned-source fallback. scripts/run.sh check exits 0 and the layout tests pass. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
fkst-loning-s-macbook-m5
Bot
deleted the
docs/env-example-documents-what-it-reads
branch
August 25, 2026 15:36
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template taught twelve FKST_* settings. Exactly one of them works.
scripts/bin_bootstrap.sh greps this file for
^BIN=and never sources it, soevery other line a reader copies into .fkst/env is inert.
Worse, the settings it taught contradict what the repository does with them.
scripts/run.sh unsets FKST_GITHUB_WRITE before
runso a single department runcannot mutate GitHub, and clears a twenty-eight variable hermetic set before
tests so they cannot read host posture -- and every FKST_GITHUB_* and
FKST_DEVLOOP_* line in the template was in that set. The file also described
supervise, an entry point this repository stopped providing when operationmoved to fkst-ops.
That is residue from the supervise-entry migration: the supply side moved to
deployment declarations plus fkst-ops, and the template stayed behind. It now
documents the one line it is read for, states where the rest actually comes
from, and says plainly why putting host posture here would do nothing twice
over.
Verified rather than asserted: bin_bootstrap.sh has one
^BIN=grep and nosource of this file; run.sh:406 unsets FKST_GITHUB_WRITE; run.sh:558 is the
hermetic clear; bin_bootstrap.sh reads .fkst/substrate-ref for the pinned-source
fallback. scripts/run.sh check exits 0 and the layout tests pass.
Co-authored-by: Claude Opus 5 (1M context) noreply@anthropic.com