Fix. Scanner. Cloud Analysis. Prevent infinite status polling. - #753
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Copilot review overview
🟡 Changes recommended
Invalid API responses can still be polled indefinitely, and missing ETAs are not stored as SQL NULL.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Prevents indefinite cloud-analysis polling by marking stale scans as errors.
Changes:
- Adds a 24-hour polling limit and terminal error handling.
- Excludes errored files from polling and manual status checks.
- Updates error-state UI messaging.
| File | Description |
|---|---|
security-malware-firewall.php |
Excludes errored scans from cron polling. |
CloudAnalysisActions.php |
Implements polling limits and error handling. |
inc/spbc-settings.php |
Updates error display and actions. |
tests/Inc/ScannerTest.php |
Content excluded by policy. |
Files excluded by content exclusion policy (1)
- tests/Inc/ScannerTest.php
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alexandergull
force-pushed
the
fix.cmws_infinite_status_polling.ag
branch
from
September 29, 2026 10:09
661cc9d to
81ee26d
Compare
alexandergull
changed the title
svedge
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/55892