Upload saltshaker report to Scout for raredisease - #5234
Conversation
Tests in stage
|
| load_config.saltshaker_report = self.get_file_from_hk( | ||
| hk_tags={"saltshaker-classify"}, hk_version=hk_version | ||
| ) |
There was a problem hiding this comment.
Did we consider adding this tag to the RAREDISEASE_CASE_TAGS? I do find the old pattern very confusing but I wonder if it will not be confusing as well to have the HK fetching done in a new way here?
There was a problem hiding this comment.
I don't find the old pattern useful. Although it is nice to have the tags listed centrally in one place, the use of that dictionary is confusing, and it entangles many parts of the code. I suspect its use was intended for something else
There was a problem hiding this comment.
I am not certain that the intent was anything but collecting all the tags in the same place (which I think might be nice preserving), but if you do not find it useful, feel free to do it like this.
|
2 participants
Description
Add the saltshaker report to the RarediseaseScoutLoadConfig
Added
saltshaker_reportto the RarediseaseScoutLoadConfigHow to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan