Conversation
Removed extra line in the README file.
Updated instructions for cloning and building the repository, and removed unnecessary details section.
Replaced and added several icon images in the AppIcon asset catalog, updated Contents.json to reference new icon files, and removed obsolete icons. Also added a new Contents.json for Images.xcassets. These changes ensure correct icon display for all required sizes and resolutions.
Updated heading for clarity and fixed formatting.
Replaced the image src URL with a new GitHub user-attachments link for improved reliability or updated content.
Deleted the credit line for wkhtmltopdf in the README.md. Updated index.pdf binary.
Updated the list of contributors and source code credits.
Replaces the previous version of index.pdf with an updated file. The changes may include new developers credits to YBronst, Hnanoto.
Expand legacy-boot docs across README.md, index.html and public/index.html: convert the short note into a dedicated "Install for legacy boot" section with detailed steps, example commands and screenshots. Instructions now specify obtaining the CloverV2 zip, copying the BootSectors/x64 folder, installing boot0af (fdisk -f boot0af -u -y), writing boot1h2 with dd, copying boot6 to the USB and placing your EFI on the USB; include notes and example paths. Also update HTML content: adjust navbar branding/links, replace several image src references, and remove the previous single-line Clover-LegacyDuet link heading. Minor formatting and punctuation fixes.
Updated theme download instructions in README.md to include CloverThemes-Gallery.
There was a problem hiding this comment.
Pull request overview
This PR removes the MacGap-based macOS “Documentation_Clover” app (and its Xcode project/workspace artifacts) from the documentation repository, while updating the documentation pages to drop app build/download instructions and refresh some links/content.
Changes:
- Deleted the MacGap app source tree, resources, and the
Documentation_Clover.xcodeprojproject/workspace user data. - Removed the app build/download section from
README.mdand refreshed top-of-page imagery and theme download guidance. - Expanded/reformatted the “legacy boot” manual installation documentation and updated the generated
index.htmlaccordingly.
Reviewed changes
Copilot reviewed 73 out of 89 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes app build/download docs; updates images, theme download info, and legacy-boot instructions |
| public/config.json | Removes MacGap app configuration |
| makefile | Removes Xcode build Makefile for the app |
| MacGap/main.m | Removes MacGap app entry point |
| MacGap/Images.xcassets/AppIcon.appiconset/Contents.json | Removes app icon asset catalog metadata |
| MacGap/en.lproj/InfoPlist.strings | Removes localized Info.plist strings |
| MacGap/en.lproj/Credits.rtf | Removes app credits resource |
| MacGap/Documentation_Clover-Prefix.pch | Removes app prefix header |
| MacGap/Documentation_Clover-Info.plist | Removes app Info.plist |
| MacGap/Constants.h | Removes MacGap app constants |
| MacGap/Classes/WindowController.m | Removes MacGap window/controller implementation |
| MacGap/Classes/WindowController.h | Removes MacGap window/controller interface |
| MacGap/Classes/WebViewDelegate.m | Removes WebView delegate implementation |
| MacGap/Classes/WebViewDelegate.h | Removes WebView delegate interface |
| MacGap/Classes/WebNotification.h | Removes WebNotification interface |
| MacGap/Classes/Utils.m | Removes app utility implementation |
| MacGap/Classes/Utils.h | Removes app utility interface |
| MacGap/Classes/NotificationProvider.m | Removes notification provider implementation |
| MacGap/Classes/NotificationProvider.h | Removes notification provider interface |
| MacGap/Classes/DraggableView.m | Removes draggable titlebar view implementation |
| MacGap/Classes/DraggableView.h | Removes draggable titlebar view interface |
| MacGap/Classes/Commands/Window.m | Removes JS-exposed window command |
| MacGap/Classes/Commands/Window.h | Removes JS-exposed window command interface |
| MacGap/Classes/Commands/Task.m | Removes JS-exposed task command |
| MacGap/Classes/Commands/Task.h | Removes JS-exposed task command interface |
| MacGap/Classes/Commands/StatusItem.m | Removes status bar item command implementation |
| MacGap/Classes/Commands/StatusItem.h | Removes status bar item command interface |
| MacGap/Classes/Commands/Sound.m | Removes sound command implementation |
| MacGap/Classes/Commands/Sound.h | Removes sound command interface |
| MacGap/Classes/Commands/Notify.m | Removes notification command implementation |
| MacGap/Classes/Commands/Notify.h | Removes notification command interface |
| MacGap/Classes/Commands/MenuItem.m | Removes menu item command implementation |
| MacGap/Classes/Commands/MenuItem.h | Removes menu item command interface |
| MacGap/Classes/Commands/Menu.m | Removes menu command implementation |
| MacGap/Classes/Commands/Menu.h | Removes menu command interface |
| MacGap/Classes/Commands/MacGap.h | Removes umbrella header for MacGap commands |
| MacGap/Classes/Commands/Fonts.m | Removes fonts command implementation |
| MacGap/Classes/Commands/Fonts.h | Removes fonts command interface |
| MacGap/Classes/Commands/File.m | Removes file command implementation |
| MacGap/Classes/Commands/File.h | Removes file command interface |
| MacGap/Classes/Commands/Event.m | Removes event bridge implementation |
| MacGap/Classes/Commands/Event.h | Removes event bridge interface |
| MacGap/Classes/Commands/Dock.m | Removes dock command implementation |
| MacGap/Classes/Commands/Dock.h | Removes dock command interface |
| MacGap/Classes/Commands/Dialog.m | Removes dialog command implementation |
| MacGap/Classes/Commands/Dialog.h | Removes dialog command interface |
| MacGap/Classes/Commands/Defaults.m | Removes defaults command implementation |
| MacGap/Classes/Commands/Defaults.h | Removes defaults command interface |
| MacGap/Classes/Commands/Command.m | Removes command base implementation |
| MacGap/Classes/Commands/Command.h | Removes command base interface |
| MacGap/Classes/Commands/Clipboard.m | Removes clipboard command implementation |
| MacGap/Classes/Commands/Clipboard.h | Removes clipboard command interface |
| MacGap/Classes/Commands/App.m | Removes app command implementation |
| MacGap/Classes/Commands/App.h | Removes app command interface |
| MacGap/Categories/NSData+Base64.m | Removes Base64 category implementation |
| MacGap/Categories/NSData+Base64.h | Removes Base64 category interface |
| MacGap/Categories/JSON.m | Removes JSON convenience category implementation |
| MacGap/Categories/JSON.h | Removes JSON convenience category interface |
| MacGap/Base.lproj/MainWindow.xib | Removes main window XIB |
| MacGap/Base.lproj/MainMenu.xib | Removes main menu XIB |
| MacGap/AppDelegate.m | Removes app delegate implementation |
| MacGap/AppDelegate.h | Removes app delegate interface |
| LICENSE-MG | Removes MacGap MIT license file (app no longer included) |
| index.html | Updates generated site HTML to match README changes (images, names, theme download text) |
| Documentation_Clover.xcodeproj/xcuserdata/Tim.xcuserdatad/xcschemes/xcschememanagement.plist | Removes user scheme management data |
| Documentation_Clover.xcodeproj/xcuserdata/Tim.xcuserdatad/xcschemes/MG.xcscheme | Removes user Xcode scheme |
| Documentation_Clover.xcodeproj/xcuserdata/Tim.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist | Removes user breakpoints list |
| Documentation_Clover.xcodeproj/xcuserdata/jeffh.xcuserdatad/xcschemes/xcschememanagement.plist | Removes user scheme management data |
| Documentation_Clover.xcodeproj/xcuserdata/chris.xcuserdatad/xcschemes/xcschememanagement.plist | Removes user scheme management data |
| Documentation_Clover.xcodeproj/project.xcworkspace/xcuserdata/Tim.xcuserdatad/WorkspaceSettings.xcsettings | Removes user workspace settings |
| Documentation_Clover.xcodeproj/project.xcworkspace/xcshareddata/MG.xccheckout | Removes workspace checkout metadata |
| Documentation_Clover.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist | Removes workspace checks metadata |
| Documentation_Clover.xcodeproj/project.xcworkspace/contents.xcworkspacedata | Removes workspace contents metadata |
| Documentation_Clover.xcodeproj/project.pbxproj | Removes the entire Xcode project definition |
Files not reviewed (1)
- Documentation_Clover.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ``` | ||
|
|
||
| </details> | ||
| <img src="https://github.com/user-attachments/assets/f7088e26-5751-4b09-a6b2-14c4315e7c02" /> |
| You can now get themes from the new [Clover Theme Repository](https://github.com/CloverHackyColor/CloverThemes) by either downloading them manually using the Terminal. or [DownGit](https://chris1111.github.io/DownGit/#/home) | ||
| You can now get themes from the new [Clover Theme Repository](https://github.com/CloverHackyColor/CloverThemes) | ||
|
|
||
| By either downloading them from [CloverThemes-Gallery](https://cloverhackycolor.github.io/CloverThemes-Gallery/) |
| When you power on your computer you see BIOS which want to start some operating system. Old computers (legacy computers) have legacy BIOS which is able to boot some drive HDD, CDROM or USB-HDD. | ||
| The BIOS read first sector (MBR) from the physical drive into memory and start is as a program written in 16bit codes. The program is less then 512 byte. It named boot0 boot sector. | ||
| The program boot0 searches the partition table of the drive, finds first partition position (PBR) on the drive and reads there first one or two sectors named boot1. Start the program. | ||
| The program PBR intended to use on the specific file-system. So use boot1hfs on HFS+ filesystem, use boot1f32 on FAT32 filesystem, boot1ex on exFAT file system and more. |
|
|
||
| `cp /CloverV2/BootSectors/x64/boot6 /Volumes/USB/boot` | ||
|
|
||
| `cp EFI (Your EFI) -> /Volumes/USB` |
| <p align="left"> | ||
|
|
||
| <img width="250" alt="1" src="https://user-images.githubusercontent.com/6248794/164569238-e9372ecc-1534-4dda-a39b-fb86304ea7a5.png"> | ||
| <img width="250" alt="1" src="https://github.com/user-attachments/assets/f7088e26-5751-4b09-a6b2-14c4315e7c02"> |
| <p>Note: At some point in the future, themes will no longer be included in the installer and instead Clover will be shipped with a single embedded theme (which it already has).</p> | ||
| <p>You can now get themes from the new <a href="https://github.com/CloverHackyColor/CloverThemes">Clover Theme Repository</a> by either downloading them manually using the Terminal. or <a href="https://chris1111.github.io/DownGit/#/home">DownGit</a></p> | ||
| <p>You can now get themes from the new <a href="https://github.com/CloverHackyColor/CloverThemes">Clover Theme Repository</a></p> | ||
| <p>By either downloading them from <a href="https://cloverhackycolor.github.io/CloverThemes-Gallery/">CloverThemes-Gallery</a></p> |
Comment on lines
+728
to
731
| <li>Slice, with help of Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, rehabman, Download-Fritz, nms42, Sherlocks, Zenit432, cecekpawon, stinga11, TheRacerMaster, solstice, Micky1979, Needy, joevt, ErmaC, vit9696, ath, savvas, syscl, goodwin_c, clovy, jief_machak, chris1111, vector_sigma, LAbyOne, Florin9doi, YBronst, Hnanoto.<h3 id="source-code-credits-to-">Source code credits to:</h3> | ||
| Intel, Apple, Oracle, Chameleon, rEFIt and Xom, nanosvg.<h3 id="packages-credits-to-">Packages credits to :</h3> | ||
| Chameleon team, crazybirdy, JrCs, chris1111.<h3 id="clover-is-open-source-based-on-different-projects-">Clover is open source based on different projects :</h3> | ||
| </li> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.