Repository navigation
Keep the supercut bin through npm 11 publish - #16
Merged
Merged
Conversation
npm 11 removes a bin entry whose path starts with ./ when it normalises package.json at publish time, so the published package would have had no supercut command. CI ran npm 10, which keeps it, so the packed install smoke job passed. Use a plain relative path, pin it with a unit test, and add an npm 11 publish dry run to CI that fails on any auto-correction.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A publish dry run on npm 11.6.2 printed
"bin[supercut]" script name dist/cli/index.js was invalid and removed: npm 11 drops a bin path written with a leading./, so the published package would have had nosupercutcommand andnpx @co-messi/supercutwould fail. CI runs npm 10, which keeps it, so the packed install smoke job passed.binpath isdist/cli/index.js(no./)test/package-name.test.tsfails on the old value, passes on the newnpm@11.6.2 publish --dry-runand fails on any auto-correctionpacked-install-smoke; verified locally with no npm loginVerified locally on npm 11.6.2: the dry run is clean, and the packed tarball installs into an empty project where
npx supercut --helpruns.