Fix possible fix(deps): 2 vulnerable dependencies in Package.resolved - #114
Open
begininvoke wants to merge 1 commit into
Open
Fix possible fix(deps): 2 vulnerable dependencies in Package.resolved#114begininvoke wants to merge 1 commit into
begininvoke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
CocoaHeads.xcworkspace/xcshareddata/swiftpm/Package.resolvedto address something a scan flagged. It is around line 237.The HTTPDecoder in NIOHTTP1 only limited individual header field size (80 KB) but imposed no overall cap on the header block size or the number of headers. An attacker can send many small, valid headers, which are accumulated into the
HTTPHeadersobject before any application code runs. This can exhaust process memory or crash downstream frameworks (e.g., Hummingbird 2) that convert headers toHTTPFields. The vulnerability is a high‑severity denial‑of‑service issue. The fix is to upgradeswift‑nioto version 2.100.0 or later, which introducesNIOHTTPDecoderLimitConfiguration. This configuration provides conservative defaults (maxHeaderFieldSize = 80 KB, maxHeaderListSize = 2 MB, maxHeaderFieldCount = 256). Exceeding any limit causes the decoder to fail withHTTPParserError.headerOverflow. Users should also explicitly setdecoderConfigurationwhere appropriate to enforce these limits.Upgrade swift‑nio to version 2.100.0 to address CVE‑2026‑2980 and CVE‑2026‑2843671.
For reference: rule
CVE-2026-28980. Rated high.I may well be missing context here — if the current code is deliberate, feel free to close this.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.