Skip to content

Add ComfyUI-CFG-Sculptor - #3230

Open
Rimor-dev wants to merge 1 commit into
Comfy-Org:mainfrom
Rimor-dev:main
Open

Add ComfyUI-CFG-Sculptor#3230
Rimor-dev wants to merge 1 commit into
Comfy-Org:mainfrom
Rimor-dev:main

Conversation

@Rimor-dev

Copy link
Copy Markdown
Contributor

Adds ComfyUI-CFG-Sculptor node pack.

Dynamic CFG sculpting with envelopes, waveforms, hysteresis, and snapshots.

Nodes included:

  • Rimor_CFGSculptorAdvanced
  • Rimor_SimKarrScheduler
  • Rimor_ModelRouter
  • Rimor_ClipRouter
  • Rimor_VaeRouter
  • Rimor_PreviewNode

Repository: https://github.com/Rimor-dev/ComfyUI-CFG-Sculptor

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 2b287a19-060a-49d6-817b-06001f2c452c

📥 Commits

Reviewing files that changed from the base of the PR and between f39cbd5 and 7681389.

📒 Files selected for processing (1)
  • node_db/dev/custom-node-list.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The development custom node catalog now includes ComfyUI-CFG-Sculptor with its repository URL, Git clone installation type, author, and feature description.

Changes

Custom node catalog

Layer / File(s) Summary
Add CFG Sculptor catalog entry
node_db/dev/custom-node-list.json
Adds ComfyUI-CFG-Sculptor by Rimor-dev with Git clone installation metadata and a description of its dynamic CFG sculpting features.

Suggested reviewers: ltdrdata

Merge Risk: ⚪ Minimal · up to 76813

This PR adds a localized node-pack catalog entry and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from ltdrdata September 1, 2026 02:25
@ltdrdata

ltdrdata commented Sep 4, 2026

Copy link
Copy Markdown
Member

The CFGSculptorAdvanced node builds its log-file path from the node_id_hidden widget value with no confinement (absolute and .. accepted), so a graph can write a .log file outside the node's logs/ directory, anywhere the server can reach.

  • nodes/cfg_sculptor_advanced.py:95

Please confine the log path to a fixed base directory (realpath + commonpath, reject absolute and ..), or derive it from a server-side value rather than the widget. I'll re-evaluate once the path is contained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants