Skip to content

Share gas fee display and editing - #1699

Merged
iosh merged 3 commits into
devfrom
review/eip5792-gas-editor
Sep 29, 2026
Merged

iosh merged 3 commits into
devfrom
review/eip5792-gas-editor

Conversation

@iosh

@iosh iosh commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Extract shared gas fee components and update the existing transaction pages to use them.


This change is Reviewable

@iosh
iosh added this pull request to stack #1700 September 24, 2026 06:45
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 48be305 to 9c33112 Compare September 24, 2026 06:54
@iosh
iosh removed this pull request from stack #1700 September 24, 2026 08:59
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 9c33112 to af8a1f4 Compare September 24, 2026 08:59
@iosh
iosh added this pull request to stack #1697 September 24, 2026 08:59
@mosshqq

mosshqq commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@codex review

@iosh
iosh force-pushed the review/eip5792-gas-editor branch from af8a1f4 to 3ce9b48 Compare September 24, 2026 10:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af8a1f4645

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 3ce9b48 to c466323 Compare September 28, 2026 02:07
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 56e12bf to dc0f195 Compare September 29, 2026 06:18
mosshqq
mosshqq previously approved these changes Sep 29, 2026
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from dc0f195 to cd2b3d8 Compare September 29, 2026 06:23
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from cd2b3d8 to 8ab8bb2 Compare September 29, 2026 06:24
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 8ab8bb2 to 492409d Compare September 29, 2026 06:48
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from 492409d to b59f791 Compare September 29, 2026 07:00
Base automatically changed from review/eip5792-transaction-estimation to dev September 29, 2026 07:04
@iosh
iosh force-pushed the review/eip5792-gas-editor branch from b59f791 to ef487fd Compare September 29, 2026 07:05
mosshqq
mosshqq previously approved these changes Sep 29, 2026
@iosh
iosh merged commit 9628fce into dev Sep 29, 2026
8 checks passed
@iosh
iosh deleted the review/eip5792-gas-editor branch September 29, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants