Skip to content

refactor(mcp): extract cohesive private modules - #819

Merged
0xLeif merged 4 commits into
mainfrom
grok/2026-10-15-specsync-mcp-modules
Oct 16, 2026
Merged

0xLeif merged 4 commits into
mainfrom
grok/2026-10-15-specsync-mcp-modules

Conversation

@0xLeif

@0xLeif 0xLeif commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Replace two textual MCP include chunks with seven private modules for transport, dispatch, confinement, preflight, snapshots, manifest discovery and publication. The facade is 105 lines and the largest implementation module is 1,322. Existing production bodies, cfg gates and the two external entry points are preserved; child tests and shared fixtures move with their code. Complete moved-source scans supplement the historical comment-only scan anchors. The independently reproduced release-test filesystem import regression is fixed.

Local validation passed: all original source-declared tests are conserved, including 124 focused MCP units and 72 MCP integration cases. Full qualification passes 2,583 unit and 462 integration tests, formatting/lint/types, release build, strict 100% contracts, 64 release-candidate controls, 29 required-CI controls and the mandatory pre-push gate. Release-test compilation fails before the import fix and passes afterward. The original combined lane failed with inherited CI/color variables; controlled same-source reruns and the remaining native stages passed, and the failed invocation is retained. Release-profile test execution and other-platform runtime qualification are not claimed.

The user explicitly approved the bounded scope. The supported SpecSync 6.1.1 workflow recorded actual definition consent, verification, agent review and same-PR finalization; the change is archived. Final committed-range Trust reports risk 32/proceed, and the unchanged attestation policy passes with truthful unsigned agent:codex notes. Strict canonical validation covers all 62 specs and 100% of paths/LOC; the final archived-tree strict lifecycle audit passes. Independent GPT parity and source review found no blocker.

Ready for corvid-agent review once updated hosted checks complete. No overlap with PR #800 lifecycle evidence or PR #815 check/fix files. Exact-head external review and required CI remain merge gates; no human code inspection, signature or statistical confidence guarantee is claimed.

Prepared by Grok and independently reviewed and verified by Codex. Preserve the two external entry points, original behavior and cfg gates, and all existing MCP tests. The included lifecycle definition remains an unapproved draft.
@0xLeif
0xLeif requested a review from corvid-agent October 16, 2026 04:58
@0xLeif
0xLeif marked this pull request as ready for review October 16, 2026 14:38
@0xLeif
0xLeif requested a review from a team as a code owner October 16, 2026 14:38
@0xLeif
0xLeif requested review from 0xGaspar, Kyntrin and tofu-ux and removed request for a team October 16, 2026 14:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T14:42:10.191744Z 7399ac9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Kyntrin Kyntrin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted review submitted at Kyntrin's request for head 7399ac9d8cbabfdcb8728e2adf484edc8758b2ae. The MCP module extraction has exact-head CI/Trust success and an automated review with no findings. I found no blocking issue in the inspected module layout and retained entry points. Approving the reviewed change. This does not represent independent human code inspection or authorize merge, deployment, or any separate lifecycle approval.

@0xLeif
0xLeif merged commit a6ffa6e into main Oct 16, 2026
23 checks passed
@0xLeif
0xLeif deleted the grok/2026-10-15-specsync-mcp-modules branch October 16, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants