Skip to content

fix: Correct spelling of "unmanaged" in MEMPACK008 DiagnosticDescriptor #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Molth wants to merge 1 commit into from
+3 −3
Closed

fix: Correct spelling of "unmanaged" in MEMPACK008 DiagnosticDescriptor #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MemoryPack.Generator/DiagnosticDescriptors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ internal static class DiagnosticDescriptors
defaultSeverity: DiagnosticSeverity.Error,
isEnabledByDefault: true);

public static readonly DiagnosticDescriptor OnMethodInUnamannagedType = new(
public static readonly DiagnosticDescriptor OnMethodInUnmanagedType = new(
id: "MEMPACK008",
title: "MemoryPackObject's On*** methods can't annotate in unamnaged struct",
title: "MemoryPackObject's On*** methods can't annotate in unmanaged struct",
messageFormat: "The MemoryPackable object '{0}' is unmanaged struct that can't annotate On***Attribute however '{1}' method annotaed",
category: Category,
defaultSeverity: DiagnosticSeverity.Error,
Expand Down
2 changes: 1 addition & 1 deletion src/MemoryPack.Generator/MemoryPackGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ public bool Validate(TypeDeclarationSyntax syntax, IGeneratorContext context, bo

if (IsUnmanagedType)
{
context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.OnMethodInUnamannagedType, item.GetLocation(syntax), Symbol.Name, item.Name));
context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.OnMethodInUnmanagedType, item.GetLocation(syntax), Symbol.Name, item.Name));
noError = false;
continue;
}
Expand Down