Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
[MemoryPackable]models.Item[]payload and add source-generator tests.Why
NativeAOT can trim the generated static interface registration method when a model is first reached as an array element. Formatter lookup then fails even though the element formatter was generated.
Scope and tradeoff
This initializer is limited to non-generic model types because open generic models need concrete type arguments. In NativeAOT, generated registrations for accessible non-generic models in the assembly are rooted and registered during module initialization.
How tested
dotnet test tests/MemoryPack.Tests/MemoryPack.Tests.csproj -c Release— 159 passed.dotnet run --project sandbox/NativeAot/NativeAot.csproj -c Release— printedA.dotnet publish sandbox/NativeAot/NativeAot.csproj -c Release -r win-x64, then ran the native executable — printedA.The NativeAOT publish still reports the existing generic formatter trim/AOT analysis warnings from
MemoryPackFormatterProvider.