fix: ensure input sandboxes assigned to transformations to avoid premature cleaning#8621
Open
ryuwd wants to merge 8 commits into
Open
fix: ensure input sandboxes assigned to transformations to avoid premature cleaning#8621ryuwd wants to merge 8 commits into
ryuwd wants to merge 8 commits into
Conversation
ryuwd
changed the title
ryuwd
changed the title
ryuwd
force-pushed
the
roneil-trf-sandbox-assignment
branch
from
fee8fed to
7018c3d
Compare
fstagni
reviewed
Jun 17, 2026
chrisburr
reviewed
Jun 17, 2026
Contributor
|
ryuwd
changed the title
Contributor
Author
|
@aldbr the PR description is updated |
ryuwd
force-pushed
the
roneil-trf-sandbox-assignment
branch
from
e8de297 to
bbb883b
Compare
…n/unpin A created-but-unpinned transformation is unsafe: its input sandbox gets cleaned on the usual timescale and every (1000s-10000s of) job submitted afterwards fails to find it. So when a transformation body references sandboxes that cannot be pinned, delete the transformation and return S_ERROR — a missing SandboxMetadataDB or a failed assignment is fatal for sandbox-bearing transformations. Symmetrically, if unassigning a transformation's sandboxes at clean/archive fails, the cleaning fails and is retried rather than proceeding: leaving the assignment behind would pin the sandboxes to a gone transformation and leak them. unassignEntities is idempotent, so the retry is safe.
…odules Rename Test_*_sandbox.py to Test_TransformationCleaningAgent.py / Test_TransformationManagerHandler.py and drive the methods with a stand-in self (no AgentModule/handler construction). Assert the contract: pinning returns S_OK/S_ERROR, a sandbox-bearing transformation with no DB or a failed assign is an error, addTransformation rolls back on a pin failure, and a failed unassignment is logged and fails the cleaning so it is retried.
Explain that a transformation references already-uploaded sandboxes via the SB: PFNs in its body's InputSandbox parameter, how to set it at creation, and that the Transformation System pins them to Transformation:<id> for the sandbox lifetime (rolling back creation if pinning fails, failing/retrying cleaning if unassignment fails).
ryuwd
force-pushed
the
roneil-trf-sandbox-assignment
branch
from
bbb883b to
c6d3b08
Compare
ryuwd
commented
Jun 25, 2026
ryuwd
commented
Jun 25, 2026
Co-authored-by: Ryunosuke O'Neil <ryunoneil@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of assigning sandboxes to transformations such that the sandboxes remain for the lifetime of the associated transformations. Transformations can make use of sandboxes to e.g. make use of software or configurations that e.g. can not be publicly distributed.
The input sandbox parameter already exists on Transformations, so this PR is not bringing sandboxes to Transformations. It is fixing the issue wherein sandboxes would be cleaned up in the usual timeframe if that were the case.
BEGINRELEASENOTES
*TransformationSystem
FIX: ensure input sandboxes assigned to transformations
ENDRELEASENOTES