Fix ravel model behaviour to properly clip OOB coordinates - #751
Merged
Merged
Conversation
Hooray! CodSpeed harness just leveled up!The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable. What changed between base and head:
Re-run the base with the same settings to get a valid performance comparison. Comparing 
Footnotes |
But not doing it doesn't break the tests
Cadair
approved these changes
Aug 20, 2026
Cadair
left a comment
Cadair
left a comment
Member
There was a problem hiding this comment.
The tests are perfect right? right?
Cadair
requested changes
Aug 20, 2026
Cadair
left a comment
Cadair
left a comment
Member
There was a problem hiding this comment.
oh wait, this bug needs regression tests.
Cadair
approved these changes
Aug 21, 2026
SolarDrew
added a commit
that referenced
this pull request
Aug 21, 2026
* Fix ravel model behaviour to properly clip OOB coordinates * Changey changey changey log * Fix ravel model behaviour to properly clip OOB coordinates * Changey changey changey log * Help help a horrible hackalump * Pooh and piglet catch a hackalump * I don't know why the result was being made into a list first But not doing it doesn't break the tests * Regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astropy v8.0.1 broke our coordinate transforms because the Ravel model wasn't clipping the lower bounds of the coordinates so it was passing numpy negative numbers. This finds the locations of the coords array where the coords are invalid and masks them out of the ravelled coords array.