Skip to content

Split doc CI into online and offline and fix devdeps - #775

Open
Cadair wants to merge 2 commits into
DKISTDC:mainfrom
Cadair:split-docs
Open

Cadair wants to merge 2 commits into
DKISTDC:mainfrom
Cadair:split-docs

Conversation

@Cadair

@Cadair Cadair commented Nov 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@Cadair Cadair added No Changelog Entry Needed This pull request does not need a changelog entry Infrastructure labels Nov 4, 2026
@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.4%

1 warning

⚠️ 6 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 11 improved benchmarks
✅ 5 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_load_asdf 2.1 s 1 s ×2
⚡ test_load_tiled_asdf 2.7 s 1.5 s +80.59%
⚡ test_dataset_save[inversion] 7.2 s 6.7 s +7.43%
⚡ test_dataset_save[large_visp_dataset] 1.6 s 1.5 s +7.24%
⚡ test_tileddataset_repr[simple-masked] 4.1 ms 3.8 ms +7.19%
⚡ test_tileddataset_repr[simple-nomask] 4.2 ms 3.9 ms +6.91%
⚡ test_dataset_repr 10 ms 9.4 ms +6.36%
⚡ test_slice_dataset 125.3 ms 117.8 ms +6.35%
⚡ test_generate_celestial 8.7 ms 8.2 ms +6.06%
⚡ test_raveled_tab1d_model 2.1 ms 2 ms +5.85%
⚡ test_plot_dataset[axes0] 8 s 7.6 s +5.35%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Cadair:split-docs (b26fc01) with main (f92b58d)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Cadair Cadair changed the title Split doc CI into online and offline Split doc CI into online and offline and fix devdeps Nov 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure No Changelog Entry Needed This pull request does not need a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant