feat: add post filter for holes and floors by sseu-buhzzi · Pull Request #681 · DanXi-Dev/DanXi

sseu-buhzzi · 2026-06-12T10:18:37Z

Close #680.

sseu-buhzzi · 2026-06-12T10:25:28Z

One problem is that buttons are now too many in the forum page. I am not sure where this new filter button should go.

This commit also introduced a `WithPostFilterBar` widget to wrap the page body and deduplicate the build logic.

w568w · 2026-06-17T09:00:09Z

Sorry for late reply. The idea LGTM, but maybe the search toolbar is too hard-core for average users? 🤔

I'm considering an "easy mode", which allows user to select filters (e.g., Like: [✔Yes] [No] [Unspecified]) .

Also, you might want to support showing a dropdown filter history list in the text field, like the post searching page we have currently, so that user doesn't need to input the same filter again and again.

…y added

Big Pickle did these when refactoring the boolean expr rows. I do not know the reason, but the UI for array and map would be designed again later.

…elds

Each slot is always bound to the parent group, which makes the expr it holds easy to operate with.

…e the latest one

sseu-buhzzi · 2026-06-24T06:18:35Z

User friendly UI selectors are like:

History and UI restoring are like:

…uilder

…tered This prevents scroll jitter when many pages are filtered out.

… group

sseu-buhzzi · 2026-07-04T03:23:50Z

This PR is ready for review now.

w568w · 2026-07-11T03:47:05Z

    final pagedListView = PagedListView<OTFloor>(
      pagedController: _listViewController,
-      noneItem: OTFloor.dummy(),
+      noneItem: OTFloor.dummyPost,


Why use a constant here? I thought we've overridden equality = for the OTFloor?

OTHole always uses such a constant OTHole.DUMMY_POST, so I added it to keep the two models similar.

DanXi/lib/page/subpage_bbs.dart

Lines 424 to 426 in 934533c

child: PagedListView<BBSPost>(

noneItem: BBSPost.DUMMY_POST,

pagedController: _listViewController,

DanXi/lib/page/subpage_bbs.dart

Lines 261 to 263 in 934533c

// About this line, see [PagedListView].

return loadedPost.isEmpty ? [BBSPost.DUMMY_POST] : loadedPost;

}

If BBSPostDetailState._loadContent ever in the future needs to return [OTFloor.DUMMY_POST] as the non-ending empty list, it can then be written the same way ForumSubpageState was.

I will update them to DUMMY_POST instead of dummyPost.

w568w · 2026-07-11T04:10:47Z

+        if (_postFilter.holeMatches(post)) post,
+    ];
+    return filtered.isEmpty
+        ? [posts.last.copyWith(meta: PostFilterPlaceholderHint(posts.length))]


I got what you want to achieve here, but there's a gotcha: PagedListView will add Dismissible for all post items, so user can swipe the hint widget to hide an invisible (but real) post.

w568w · 2026-07-11T04:13:02Z

-            },
+            child: WithPostFilterBar(
+              filter: _postFilter,
+              onApply: (expr) => setState(() => _postFilter.apply(expr)),


Will setState(() => _postFilter.apply(expr)) trigger a refresh of the list view? Otherwises, the shown items on the screen will not be refiltered.

No, it will not be refreshed. In the main "forum subpage" or the "hole detail" page the user can refresh to get the filtered view.

But in some other render models like "my replies", it does not support pull-down-refresh, so it would be a bug there that the filter never filters the posts. I will fix it.

w568w · 2026-07-11T04:14:28Z

We use the current _listViewController.length() as the offset for next loading. So if you filter the post list data, maybe the offset will be wrong here.

DanXi/lib/page/forum/hole_detail.dart

Lines 154 to 159 in 94f702a

MyReplies() => (await ForumRepository.getInstance()

.loadUserFloors(startFloor: _listViewController.length()))

// Filter manually hidden floors

.filter((element) => !SettingsProvider.getInstance()

.hiddenMyReplies

.contains(element.floor_id)),

This person filter that has already been existing could also generate wrong offsets with using _listViewController.length() as startFloor. I think the fix could be to replace some of these .length() occurrences with page * Constant.POST_COUNT_PER_PAGE like the Normal render model.

sseu-buhzzi · 2026-07-28T03:18:24Z

Sorry for not noticing the reviews recently, I will apply the commented changes as soon as possible.

- Extract PostFilterPlaceholderHint into lib/util so hole and floor models do not depend on lib/widgets. - Replace untyped `Object? meta` with `PostFilterPlaceholderHint? pfHint` on OTHole and OTFloor.

…ggled

…e pages not all posts in which are filtered out

… offset This avoids the mismatches of offset of content between the fetched and the list view controller stored made by filters

…tch all

w568w · 2026-08-17T10:45:54Z

Sorry for the laaaaaaate reply. I'm so busy recently, thus having no time to review it. I might get it done this week.

sseu-buhzzi · 2026-08-30T16:20:03Z

I will try to implement the support for keyboard shortcuts like <C-F> and / next weekend. I would be busy in the coming workdays too.

sseu-buhzzi added 6 commits June 11, 2026 22:57

feat(forum): filter posts by regexes

73a3beb

fix(paged-list): defer loading outside layout phase

aaee996

feat(post-filter): add Javascript evaluation support

54fc7d6

feat(post-filter): add the JS filter

3c5c6b3

feat(post-filter): add post filter in the hole detail page

dbcf075

refactor(forum): save separate post filter patterns

098a27e

sseu-buhzzi changed the title ~~feat: add post filter~~ feat: add post filter for holes and floors Jun 12, 2026

sseu-buhzzi added 5 commits June 12, 2026 19:05

refactor(post-filter): move the post map data builders

c5613bf

chore(post-filter): move the sort order and filter button into one

17b2f17

refactor(post-filter): extract the similar logic to match posts

858509e

feat(post-filter): disable filters when the bar is not shown

ae55d62

fix(post-filter): ensure correct paddings in the cupertino theme

7bdb9a7

This commit also introduced a `WithPostFilterBar` widget to wrap the page body and deduplicate the build logic.

sseu-buhzzi marked this pull request as ready for review June 16, 2026 03:55

chore(post-filter): move the filter button into the option menu

4dadb6d

sseu-buhzzi added 14 commits June 18, 2026 12:24

feat(post-filter): remove the regex filter

029ac1f

feat(psot-filter): implement the fields selector UI

f857ec1

feat(post-filter): add the avatars for expr group relations

ab414cd

fix(post-filter): use compatible colors

6767b50

fix(post-filter): make the exprs area vertically scrollable

e586e4c

fix(post-filter): use spacing

9ff5303

feat(post-filter): expand the menu when the field selecteor is firstl…

06965b0

…y added

chore(post-filter): skip fields of array and map types

a4d2029

Big Pickle did these when refactoring the boolean expr rows. I do not know the reason, but the UI for array and map would be designed again later.

feat(post-filter): use no method selector for boolean selectors

c74df1a

feat(post-filter): use toggle button instead of menu for togglable fi…

e6e5a47

…elds

refactor(post-filter): simplify the logic to show the add expr popup

7728feb

chore(post-filter): use a string value input dialog

9cf08ed

fix(post-filter): use the correct abstraction for slots

d529765

Each slot is always bound to the parent group, which makes the expr it holds easy to operate with.

chore(post-filter): rename and comment the code

9985889

sseu-buhzzi added 2 commits June 24, 2026 13:18

refactor(post-filter): make condition verb nullable

67cc1f6

fix(post-filter-history): use a per-page cached history to deduplicat…

9571a0f

…e the latest one

sseu-buhzzi force-pushed the 20260611/feat-post-filter branch from c3c91bc to 9571a0f Compare June 24, 2026 06:05

fix(post-filter): use true as placeholder for incomplete expressions

083ab45

sseu-buhzzi added 7 commits June 24, 2026 14:29

update(post-fliter): fix a case problem

d8c5473

refactor(post-filter): apply the filter on data receiver instead of b…

c6c4870

…uilder

fix(post-filter): add a placholder hint text when a whole page is fil…

4988008

…tered This prevents scroll jitter when many pages are filtered out.

feat(post-filter): support toggling human duration and absolute time

fd33709

fix(post-filter): add the button in other hole detail render models

ba1234b

fix(model): reorder parameters time_created and time_updated

0f152c0

feat(post-filter): open the expr selector on init when no expr in the…

4bf6fc0

… group

w568w requested changes Jul 11, 2026

View reviewed changes

sseu-buhzzi added 9 commits August 1, 2026 17:07

refactor(post-filter): type the meta field as pfHint

1efba66

- Extract PostFilterPlaceholderHint into lib/util so hole and floor models do not depend on lib/widgets. - Replace untyped `Object? meta` with `PostFilterPlaceholderHint? pfHint` on OTHole and OTFloor.

style(model): rename dummyPost to DUMMY_POST

b4427a1

style(post-filter): reorder PostFilterToggleButton

5381994

fix(post-filter): avoid hint items be slided away and dismissed

ebb875c

fix(post-filter): auto refresh after the post filter is applied or to…

4657e32

…ggled

feat(post-filter): add placeholder hints for filtered out posts insid…

4feb5ca

…e pages not all posts in which are filtered out

fix(paged-list-view): use page with POST_COUNT_PER_PAGE to locate the…

eeed8f5

… offset This avoids the mismatches of offset of content between the fetched and the list view controller stored made by filters

refactor(post-filter): reuse _loadContent for the image viewer

ffbdb9d

fix(paged-list-view): also filter the floors in the ad-hoc path to fe…

f652644

…tch all

sseu-buhzzi force-pushed the 20260611/feat-post-filter branch from 7512b4b to f652644 Compare August 2, 2026 13:01

sseu-buhzzi requested a review from w568w August 2, 2026 14:14

Merge branch 'main' into 20260611/feat-post-filter

8ec8589

w568w linked an issue Aug 30, 2026 that may be closed by this pull request

[Feature Request]楼层添加对键盘上Home,Pgup,Pgdn,End等键的支持，添加搜索功能 #576

Open

	child: PagedListView<BBSPost>(
	noneItem: BBSPost.DUMMY_POST,
	pagedController: _listViewController,

	// About this line, see [PagedListView].
	return loadedPost.isEmpty ? [BBSPost.DUMMY_POST] : loadedPost;
	}

	MyReplies() => (await ForumRepository.getInstance()
	.loadUserFloors(startFloor: _listViewController.length()))
	// Filter manually hidden floors
	.filter((element) => !SettingsProvider.getInstance()
	.hiddenMyReplies
	.contains(element.floor_id)),

Uh oh!

Conversation

sseu-buhzzi commented Jun 12, 2026

Uh oh!

sseu-buhzzi commented Jun 12, 2026

Uh oh!

w568w commented Jun 17, 2026

Uh oh!

sseu-buhzzi commented Jun 24, 2026

Uh oh!

sseu-buhzzi commented Jul 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

w568w Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

sseu-buhzzi Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

w568w Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

w568w Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

sseu-buhzzi Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

w568w Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

sseu-buhzzi Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sseu-buhzzi commented Jul 28, 2026

Uh oh!

w568w commented Aug 17, 2026

Uh oh!

sseu-buhzzi commented Aug 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants